Replace removed tolerate-unready-endpoints annotation with publishNotReadyAddresses #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notation that got removed in k8s 1.24 - service.alpha.kubernetes.io/tolerate-unready-endpoints was removed in k8s 1.24 with commit kubernetes/kubernetes@ae9f117
zerbitx
approved these changes
Jul 10, 2023
ericsyh
approved these changes
Jul 21, 2023
ericsyh
pushed a commit
that referenced
this pull request
Aug 24, 2023
…ReadyAddresses (#1066) Use publishNotReadyAddresses instead of tolerate-unready-endpoints annotation that got removed in k8s 1.24 - service.alpha.kubernetes.io/tolerate-unready-endpoints was removed in k8s 1.24 with commit kubernetes/kubernetes@ae9f117 Co-authored-by: Eric Shen <[email protected]> (cherry picked from commit 9e94e40)
ericsyh
pushed a commit
that referenced
this pull request
Aug 24, 2023
…ReadyAddresses (#1066) Use publishNotReadyAddresses instead of tolerate-unready-endpoints annotation that got removed in k8s 1.24 - service.alpha.kubernetes.io/tolerate-unready-endpoints was removed in k8s 1.24 with commit kubernetes/kubernetes@ae9f117 Co-authored-by: Eric Shen <[email protected]> (cherry picked from commit 9e94e40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
StreamNative Pulsar helm chart isn't compatible with k8s 1.24+ since there isn't a way to configure Zookeeper service with
publishNotReadyAddresses: true.service.alpha.kubernetes.io/tolerate-unready-endpointsannotation was removed in k8s 1.24 with commit kubernetes/kubernetes@ae9f117Modifications
publishNotReadyAddresses: truefor zookeeper servicesservice.alpha.kubernetes.io/tolerate-unready-endpointsannotationDocumentation
no-need-doc