Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.6.4 pre #3526

Closed

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Jan 4, 2024
bgurney-rh and others added 11 commits January 4, 2024 10:49
This step was done partially in a prior PR, this just completes that.

See: stratis-storage#3064

Signed-off-by: mulhern <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Clippy 1.75.0 is showing initialize_devices as an unused import, but
it is used in a test in strat_engine/liminal/identify.rs.

Signed-off-by: Bryan Gurney <[email protected]>
stratisd does not need to suppress output via -q option to thin_check
because the cmd module captures stderr and stdout streams and only reads them
if the command returns an error.

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran force-pushed the version-3.6.4-pre branch 2 times, most recently from ffc4788 to e315f21 Compare January 4, 2024 16:53
@mulkieran
Copy link
Member Author

This was the test:

+        if cmd.get_program().to_string_lossy().contains(THIN_CHECK) {
+            let std_out_txt = String::from_utf8_lossy(&output.stdout);
+            let std_err_txt = String::from_utf8_lossy(&output.stderr);
+            info!("Command succeeded: cmd: {cmd:?}, stdout: {std_out_txt} stderr: {std_err_txt}");
+        }

this was the typical output:

stdout: TRANSACTION_ID=0
    METADATA_FREE_BLOCKS=1015
     stderr: Checking thin metadata
    device details tree
    mapping tree
    data space map
    metadata space map

@mulkieran mulkieran closed this Jan 11, 2024
@mulkieran mulkieran deleted the version-3.6.4-pre branch January 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants