Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Status showBullet option #1802

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore: remove Status showBullet option #1802

merged 1 commit into from
Oct 29, 2024

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Oct 28, 2024

What does it do?

Remove the showBullet option from the Status component. It was a leftover from the CMS v4 designs that is not in use anymore. This v2 RC is our chance to get rid of it (see the comment that was in the code)

Why is it needed?

Cleaning up dead code

@remidej remidej added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package labels Oct 28, 2024
@remidej remidej self-assigned this Oct 28, 2024
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 24274b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:53am

@lucasboilly
Copy link

@remidej all good, this option is not relevant anymore in v5 :)

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It looks like in the CMS we are always setting it to false but I guess we need a follow up PR over there to remove the prop entirely. Do we need to communicate / align with cloud on this change?

@remidej
Copy link
Contributor Author

remidej commented Oct 29, 2024

Let me check. @HichamELBSI is this okay for the cloud team? I searched your code and it looks like you always pass showBullet={false}. So it won't impact your UI but it means you'll have to remove that prop when upgrading to the latest DS RC

@remidej remidej requested a review from HichamELBSI October 29, 2024 09:59
Copy link
Collaborator

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for the Cloud, we aren't using them anymore as well 👍🏽

@remidej remidej merged commit 8f70728 into main Oct 29, 2024
12 checks passed
@remidej remidej deleted the chore/rm-bullet branch October 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants