-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Status showBullet option #1802
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@remidej all good, this option is not relevant anymore in v5 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
It looks like in the CMS we are always setting it to false but I guess we need a follow up PR over there to remove the prop entirely. Do we need to communicate / align with cloud on this change?
Let me check. @HichamELBSI is this okay for the cloud team? I searched your code and it looks like you always pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for the Cloud, we aren't using them anymore as well 👍🏽
What does it do?
Remove the showBullet option from the Status component. It was a leftover from the CMS v4 designs that is not in use anymore. This v2 RC is our chance to get rid of it (see the comment that was in the code)
Why is it needed?
Cleaning up dead code