Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: props table not showing #1788

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix: props table not showing #1788

merged 4 commits into from
Sep 23, 2024

Conversation

Bassel17
Copy link
Member

What does it do?

  • Upgrade Storybook packages to 8.3.1

  • remove @storybook/blocks patch version from the root package.json

  • switch TableType component with ArgTypes in storybook docs

Why is it needed?

  • TypeTable doesn't exist anymore no props table is generated in the Storybooks
  • The resolution patch version of @storybook/blocks doesn't seem to be needed, we were already using 8.1.6 version

How to test it?

  • run storybook, check the Docs, you will see props tables for a lot of the components

Note
Will be working on a strategy to improve the docs better, as for some component ArgTypes did not manage to automatically generate a table of the props

@Bassel17 Bassel17 added pr: fix This PR is fixing a bug source: docs relates to the docs of the project labels Sep 20, 2024
@Bassel17 Bassel17 added this to the v2.0.0 milestone Sep 20, 2024
@Bassel17 Bassel17 self-assigned this Sep 20, 2024
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: bcaf977

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 11:47am

Copy link
Member

@butcherZ butcherZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice to have this working 🫶

@Bassel17 Bassel17 merged commit 9633f19 into main Sep 23, 2024
10 of 12 checks passed
@Bassel17 Bassel17 deleted the fix/props-table-not-showing branch September 23, 2024 13:47
@echoes-hq echoes-hq bot added the echoes: bug Changes intended at preserving our ability to evolve the software safely and effectively label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bug Changes intended at preserving our ability to evolve the software safely and effectively pr: fix This PR is fixing a bug source: docs relates to the docs of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants