Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Wasmd Fork ADR #100

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat: add Wasmd Fork ADR #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d4853a
Add Wasmd Fork ADR
joelsmith-2019 Nov 6, 2024
902b5bb
Fix Typos
joelsmith-2019 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cspell-custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ Solana's
spydk
Starport
statesync
Strangelove
struct
structs
subdenom
Expand Down Expand Up @@ -194,6 +195,7 @@ varint
varints
vimdiff
vphash
wasmd
wasmhooks
wasms
WORKDIR
Expand Down
19 changes: 19 additions & 0 deletions wormchain/docs/architecture/0006-transfer-wasmd-fork-logic-to-wormchain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# 6. Transfer Wasmd Fork Logic to Wormchain Ante Handler

Date: 2024-07-29

## Status

Accepted

## Context

The Wormchain repo depends on a fork of `wasmd` to prevent certain types of Wasm transactions from being accepted by the chain. The Strangelove team proposed migrating the logic to an Ante Handler on chain to remove the need to maintain a fork of `wasmd`.

## Decision

After some discussion and investigation, the Strangelove team has decided to transfer the fork logic to an Ante Handler on Wormchain. This will allow the Wormchain to be more in line with the Cosmos SDK and reduce the maintenance overhead of maintaining a fork of `wasmd`.

## Consequences

The Wormchain will no longer depend on a fork of `wasmd` and will be able to upgrade to newer versions of the Cosmos SDK more easily. The Strangelove team will need to implement the Ante Handler and test it to ensure that it works as expected. As of now, the Strangelove team has not identified any major risks associated with this decision.
Loading