Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: poa fixes, tweaks, and chores #237

Merged
merged 12 commits into from
Dec 18, 2024
Merged

refactor: poa fixes, tweaks, and chores #237

merged 12 commits into from
Dec 18, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Dec 16, 2024

  • Also migrates all int64 -> uint64 to just a sdkmath.NewIntFromUint64(uint64) consumer, rather than type converting. Makes linter happy :)

@Reecepbcups
Copy link
Member Author

Reecepbcups commented Dec 16, 2024

Simulation test failure is due to the new logic for denying duplicate ba78c0c

Will fix later. Other CI 2 failures are unrelated. Main e2e & test run as expected

@Reecepbcups Reecepbcups changed the title refactor: poa tweaks refactor: poa fixes, tweaks, and chores Dec 18, 2024
@Reecepbcups Reecepbcups marked this pull request as ready for review December 18, 2024 01:33
@Reecepbcups Reecepbcups merged commit 9e804c6 into main Dec 18, 2024
14 checks passed
@Reecepbcups Reecepbcups deleted the reece/poa-tweaks branch December 18, 2024 01:41
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 70.76923% with 19 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (6922e22) to head (ac705e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
keeper/msg_server.go 57.89% 10 Missing and 6 partials ⚠️
simulation/operations.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   60.01%   58.46%   -1.56%     
==========================================
  Files          44       44              
  Lines        2116     2754     +638     
==========================================
+ Hits         1270     1610     +340     
- Misses        662      956     +294     
- Partials      184      188       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant