Merge branch 'next' into improve-test-runner

storybookjs · Nov 8, 2023 · c2d45cf · c2d45cf
2 parents 538c50a + 33f2385
commit c2d45cf
Show file tree

Hide file tree

Showing 12 changed files with 963 additions and 949 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug-report-🐞.md b/.github/ISSUE_TEMPLATE/bug-report-🐞.md
@@ -1,17 +1,17 @@
 ---
 name: "Bug report \U0001F41E"
 about: Create a report to help us improve
-title: "[bug] "
+title: '[bug] '
 labels: bug, needs triage
 assignees: ''
-
 ---
 
 **Describe the bug**
 A clear and concise description of what the bug is.
 
 **To Reproduce**
 Steps to reproduce the behavior:
+
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'

diff --git a/.storybook/main.ts b/.storybook/main.ts
@@ -1,3 +1,5 @@
+import { StorybookConfig } from '@storybok/react-vite';
+
 let stories = [
   '../stories/docs/**/*.mdx',
   // default title prefix
@@ -28,7 +30,7 @@ const addons = [
   '@storybook/addon-interactions',
   '@storybook/addon-coverage',
 ];
-module.exports = {
+const config: StorybookConfig = {
   stories,
   addons,
   features: {
@@ -46,3 +48,5 @@ module.exports = {
     autodocs: true,
   },
 };
+
+export default config;
diff --git a/.storybook/test-runner.ts b/.storybook/test-runner.ts
@@ -1,5 +1,5 @@
 import { toMatchImageSnapshot } from 'jest-image-snapshot';
-import { getStoryContext } from '../dist/playwright/hooks';
+import { getStoryContext, waitForPageReady } from '../dist/playwright/hooks';
 import type { TestRunnerConfig } from '../dist';
 
 const snapshotsDir = process.env.SNAPSHOTS_DIR || '__snapshots__';
@@ -22,6 +22,8 @@ const config: TestRunnerConfig = {
       return;
     }
 
+    await waitForPageReady(page);
+
     // Visual snapshot tests
     const image = await page.screenshot({ fullPage: true });
     expect(image).toMatchImageSnapshot({