fix: publish location claim to content claims service #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeja
approved these changes
Oct 31, 2024
| body: data, | ||
| headers: address.headers, | ||
| }) | ||
| assert.equal(httpPut.status, 200, await httpPut.text()) |
There was a problem hiding this comment.
suggestion: await httpPut.text() seems like a less-than-ideal assertion message to me. I see it's copying the pattern from blob/add schedules allocation and returns effects for allocate, accept and put together with their receipts (when stored). Could we give both these assertions more meaningful messages? Maybe something like:
Suggested change
| assert.equal(httpPut.status, 200, await httpPut.text()) | |
| assert.equal(httpPut.status, 200, `PUT ${address.url} failed (${httpPut.status}): ${await httpPut.text()}`) |
fforbeck
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big oversight here, although I think the original intention was to have the client publish these so perhaps not.
Anyways, since no location claims are being published the gateway cannot fetch an index and serve bytes quickly. It has to get a location claim for every single block using the old dynamodb. Being able to use the index will result in a speed increase for serving content via the gateway.
Depends on storacha/content-claims#74 for passing tests.