Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customers to create more than one space #246

Merged
merged 3 commits into from
Oct 26, 2023

Commits on Oct 19, 2023

  1. feat: allow customers to create more than one space

    this is just a matter of changing how we generate subscription IDs. they are now generated from customer AND consumer, which means they will be unique for a given customer/consumer pair - in other words, a given customer will only be able to provision a given space one time.
    travis committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5e2e9ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e78b896 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. feat: generate subscription id from consumer only

    @alanshaw pointed out that as implemented, a space could be registered by more than one user, which would make billing pretty challenging.
    
    I tried to write a test for this, but w3up-client and access-client go to some lengths to stop a user from registering another user's space so this is a deeper rabbithole than I'd like to go down for now.
    travis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    aafebb2 View commit details
    Browse the repository at this point in the history