-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Problems Description: 2 - cat gifs, and 3 - delegation #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought, you might want to update the challenge title here: https://github.com/storacha-network/learnyouw3up/blob/d661501bb8b675bccbb5465e44ed8bc7e2f118e9/bin.js#L21 ...to be "memes" instead of "gifs"?
Co-authored-by: Alan Shaw <[email protected]>
Co-authored-by: Alan Shaw <[email protected]>
.bin changed |
@@ -18,7 +18,7 @@ const shop = adventure({ | |||
|
|||
shop.add('Introduction: UCAN do it!', () => IntroductionProblem) | |||
shop.add('Lets space out', () => SpaceOutProblem) | |||
shop.add('Storing cat gifs for fun and gossip', () => CatGifsProblem) | |||
shop.add('Storing cat memes for fun and gossip', () => CatMemesProblem) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rename CatGifsProblem
in the imports above also if you rename it here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request improves the instructions for Challenge 2 - Cats gifs, and Challenge 3-Delegation by breaking down the steps into smaller, more manageable parts.