Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Problems Description: 2 - cat gifs, and 3 - delegation #20

Merged
merged 10 commits into from
Aug 15, 2024

Conversation

hakierka
Copy link
Member

@hakierka hakierka commented Aug 5, 2024

This pull request improves the instructions for Challenge 2 - Cats gifs, and Challenge 3-Delegation by breaking down the steps into smaller, more manageable parts.

@hakierka hakierka changed the title Edit Problem Description - 3 Delegation Edit Problems Description: 2 - cat gifs, and 3 - delegation Aug 5, 2024
@hakierka hakierka requested a review from alanshaw August 5, 2024 11:46
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, you might want to update the challenge title here: https://github.com/storacha-network/learnyouw3up/blob/d661501bb8b675bccbb5465e44ed8bc7e2f118e9/bin.js#L21 ...to be "memes" instead of "gifs"?

problems/2-cat-gifs/problem.md Outdated Show resolved Hide resolved
problems/3-delegation/problem.md Outdated Show resolved Hide resolved
@hakierka
Copy link
Member Author

hakierka commented Aug 5, 2024

.bin changed

@@ -18,7 +18,7 @@ const shop = adventure({

shop.add('Introduction: UCAN do it!', () => IntroductionProblem)
shop.add('Lets space out', () => SpaceOutProblem)
shop.add('Storing cat gifs for fun and gossip', () => CatGifsProblem)
shop.add('Storing cat memes for fun and gossip', () => CatMemesProblem)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rename CatGifsProblem in the imports above also if you rename it here!

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hakierka hakierka closed this Aug 8, 2024
@hakierka hakierka deleted the amy-edit branch August 8, 2024 11:51
@hakierka hakierka restored the amy-edit branch August 15, 2024 12:35
@hakierka hakierka reopened this Aug 15, 2024
@hakierka hakierka merged commit 269ef09 into storacha:main Aug 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants