fix: most problem.md said verify program.mjs but now say verify ex{N}.mjs
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` because that wasn't obvious to me and I called mine `ex1.mjs` which was mentioned earlier in the problem
…(I read it as auth related)
alanshaw
requested changes
Nov 16, 2023
problems/0-introduction/problem.md
Outdated
| @@ -18,7 +18,7 @@ When you succeed, you type `learnyouw3up` again and select the next exercise. | |||
|
|
|||
| Rinse and repeat for each excercise. Got it? Good. | |||
|
|
|||
| Ok, now I need you to make that JS file we talked about. For this exercise we're going to print out your DID. Yeah, like an ID, but DECENTRALIZED. Woof. | |||
| Ok, now I need you to make that JS file we talked about, and call it `program.mjs`. For this exercise we're going to print out your DID. Yeah, like an ID, but DECENTRALIZED. Woof. | |||
There was a problem hiding this comment.
Hmm, just below it says "When you're done, verify your solution with learnyouw3up verify ex1.mjs...".
Perhaps we should change "To verify your program, run: $ADVENTURE_NAME verify program.mjs" instead (so it reads ex1.mjs)? We'd need to change for every problem.
There was a problem hiding this comment.
great point. I didn't recognize the pattern until after I submitted this and I'd gotten to ex2 and beyond
There was a problem hiding this comment.
I updated the PR to change this to saying 'and call it ex1.mjs' and change the bottom from program.mjs to ex1.mjs. And I changed the bottom of all the other problem.md that said program.mjs
Co-authored-by: Alan Shaw <[email protected]>
…fy program.mjs' and now says 'verify ex{N}.json'
gobengo
changed the title
program.mjs because that wasn't obvious to me and I called mine ex1.mjs which was mentioned earlier in the problemprogram.mjs because that wasn't obvious to me and I called mine ex1.mjs which was mentioned earlier in the problem
gobengo
changed the title
program.mjs because that wasn't obvious to me and I called mine ex1.mjs which was mentioned earlier in the problemverify program.mjs but now say verify ex{N}.mjs
alanshaw
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.