Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds agreement feedback component #1007

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

fellmirr
Copy link
Member

Adds a component for providing feedback when cancelling agreements

TODO:

  • Add support for freetext field in feedback
  • Add support for ordering feedback options when displaying them

Tested on devices

  • Desktop 💻
  • Mobile 📱

Tests

  • All tests are running ✔️
  • Test are updated 🧪
  • Code Review 👩‍💻
  • QA 👌

Checkpoints

Check these to flag for a more thurough review, as they could be potentially breaking changes

  • Packages updated
  • Other infrastructure updated (such as node version or similar)

⏲️ Time spent on CR:

⏲️ Time spent on QA:

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ge-effektivt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 11:17am
main-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 11:17am

Copy link

cypress bot commented Nov 14, 2024

Main site    Run #4420

Run Properties:  status check passed Passed #4420  •  git commit 5ffe38ecc9: Removes lightbox background blur due to terrible performance
Project Main site
Run status status check passed Passed #4420
Run duration 00m 16s
Commit git commit 5ffe38ecc9: Removes lightbox background blur due to terrible performance
Committer Håkon Harnes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant