Fix coveralls (#148, #149), fix tests

steverobbins · Oct 31, 2018 · afedfe5 · afedfe5
1 parent 6c44357
commit afedfe5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -6,10 +6,10 @@ branches:
     - dev
 
 php:
-  - 5.5
   - 5.6
   - 7.0
-  - hhvm
+  - 7.1
+  - 7.2
 
 before_script:
     - travis_retry composer self-update

diff --git a/composer.json b/composer.json
@@ -15,7 +15,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "~4.0",
-        "satooshi/php-coveralls": "dev-master",
+        "satooshi/php-coveralls": "1.1.*",
         "squizlabs/php_codesniffer": "2.*"
     },
     "autoload": {

diff --git a/src/MageScan/Check/Sitemap.php b/src/MageScan/Check/Sitemap.php
@@ -40,7 +40,7 @@ public function getSitemapFromRobotsTxt(Response $response)
     {
         return $this->getRequest()->findMatchInResponse(
             $response->getBody()->getContents(),
-            '/^(?!#+)\s*Sitemap:\w+(.*)$/mi'
+            '/^(?!#+)\s*Sitemap:\s+(.*)$/mi'
         );
     }
 }
diff --git a/src/MageScan/Check/Version/DownloaderComment.php b/src/MageScan/Check/Version/DownloaderComment.php
@@ -126,7 +126,8 @@ protected function getMagentoEditionByYearAndVersion($year, $version)
                     '1.4.1.0',
                     '1.4.1.1',
                     '1.4.2.0',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;
@@ -138,7 +139,8 @@ protected function getMagentoEditionByYearAndVersion($year, $version)
                     '1.6.0.0',
                     '1.6.1.0',
                     '1.6.2.0',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;
@@ -147,15 +149,17 @@ protected function getMagentoEditionByYearAndVersion($year, $version)
                     '1.7.0.0',
                     '1.7.0.1',
                     '1.7.0.2',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;
             case 2013:
                 if (in_array($version, [
                     '1.8.0.0',
                     '1.8.1.0',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;
@@ -165,7 +169,8 @@ protected function getMagentoEditionByYearAndVersion($year, $version)
                     '1.9.0.1',
                     '1.9.1.0',
                     '1.9.1.1',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;
@@ -175,15 +180,17 @@ protected function getMagentoEditionByYearAndVersion($year, $version)
                     '1.9.2.0',
                     '1.9.2.1',
                     '1.9.2.2',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;
             case 2016:
                 if (in_array($version, [
                     '1.9.2.3',
                     '1.9.2.4',
-                ])) {
+                ])
+                ) {
                     return Version::EDITION_COMMUNITY;
                 }
                 break;