Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TinyMCE 4.9.1 #1906

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to TinyMCE 4.9.1 #1906

wants to merge 2 commits into from

Conversation

gual
Copy link

@gual gual commented Dec 12, 2018

When enabling imagetools plugin for current version of TinyMCE (4.1.0) I got the error module definition dependecy not found: tinymce/util/Promise. Upgrading to TinyMCE 4.9.1 made the plugin and the editor work as expected. Tests results on OK.

PS: I followed the guidelines, let me know if there is something else required or something I missed. Thanks!

@stephenmcd
Copy link
Owner

#1896 is open with a slightly older version - that PR contained some visual issues that needed to be resolved. Can you confirm these aren't present with this PR, and if they are, resolve them first?

Thanks a lot.

@gual
Copy link
Author

gual commented Dec 13, 2018

@stephenmcd I checked #1896.

Fullscreen issue

I wasn't able to reproduce any issue on my branch. I get the same behavior with the current tinymce version as with the new one (the expected one).

Current:
anadir_publicacion___mezzanine_and_upgrade_to_tinymce_4_9_1_by_gual_ _pull_request__1906_ _stephenmcd_mezzanine

Updated:
anadir_publicacion___mezzanine

Styling issues

I did had the same issue of the editor blowing out into the left-hand column where field names were listed. The reason behind this change was that the new default value for width was 100% and previously it had auto. I added the width option explicit on the default setup and voila...

anadir_publicacion___mezzanine

@gual
Copy link
Author

gual commented Dec 13, 2018

As for the

Front-end Editing

I get the same behavior with the new version.

Current:
blog___funde

Updated:
blog___funde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants