Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/csr retrieve entity #1246
base: feature/new-csr
Are you sure you want to change the base?
Feature/csr retrieve entity #1246
Changes from 5 commits
41e4af9
c7bff1e
cc6de35
e89f92f
3de35ba
53f0b87
c8bf170
e8ccf0c
8387130
dd31576
3bcf7b3
690fd59
f38c04b
129228a
b07e032
6d4831a
8740239
f74ceec
deca20c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you also have to filter CSRs that match the current operation (so
retrieveEntity
in the operations orfederationOps
in the operation groups)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filtering the results from the call to the service is not a clean way to do it. it should be part of the call to the service.