Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-1424] ReCaptcha race condition prevents it from loading #477

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

marwen-abid
Copy link
Collaborator

What

Add a method to ensure ReCaptcha is loaded before rendering it.

Why

https://developers.google.com/recaptcha/docs/loading#loading_recaptcha_asynchronously

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marwen-abid marwen-abid self-assigned this Nov 26, 2024
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:27 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 26, 2024 01:27 — with GitHub Actions Inactive
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:27 — with GitHub Actions Failure
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:27 — with GitHub Actions Error
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:27 — with GitHub Actions Error
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 01:27 — with GitHub Actions Error
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:33 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:43 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 01:43 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 01:43 — with GitHub Actions Inactive
@marwen-abid marwen-abid merged commit 550a7e6 into develop Nov 26, 2024
17 checks passed
@marwen-abid marwen-abid deleted the bugfix/SDP-1424-recaptcha-race-condition branch November 26, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants