Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] support XLM in integration tests #470

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[Fix] support XLM in integration tests #470

merged 3 commits into from
Nov 27, 2024

Conversation

marcelosalloum
Copy link
Collaborator

@marcelosalloum marcelosalloum commented Nov 22, 2024 •
edited
Loading

What

Support xlm in integration tests

Why

It's a good practice to support it, and it was needed to test e2e on futurenet

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marcelosalloum marcelosalloum self-assigned this Nov 22, 2024
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 22, 2024 21:50 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests November 22, 2024 21:50 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 22, 2024 21:50 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 22, 2024 21:50 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 22, 2024 21:50 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 22, 2024 21:50 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr470.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr470.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr470.previews.kube001.services.stellar-ops.com

@marcelosalloum
Copy link
Collaborator Author

I'll hold off on this PR while we focus on the 3.0 release. I'll mark it as DRAFT for now.

@marcelosalloum marcelosalloum marked this pull request as draft November 25, 2024 16:18
@marcelosalloum marcelosalloum changed the title [Fix] support xlm in integration tests [Fix] support XLM in integration tests Nov 25, 2024
@marcelosalloum marcelosalloum force-pushed the fix/support-XLM-in-integration-tests branch from 490dbe6 to df7fcff Compare November 26, 2024 23:53
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests November 26, 2024 23:53 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 23:53 — with GitHub Actions Inactive
marcelosalloum
marcelosalloum commented Nov 26, 2024
View reviewed changes
cmd/integration_tests.go
@@ -33,7 +33,7 @@ func (c *IntegrationTestsCommand) Command() *cobra.Command {
Usage: "Issuer if the asset to be disbursed",
OptType: types.String,
ConfigKey: &integrationTestsOpts.DisbursetAssetIssuer,
Required: true,
Required: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked as false so XLM can be supported.

@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr470.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr470.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr470.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum marked this pull request as ready for review November 27, 2024 18:09
marwen-abid
marwen-abid reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcelosalloum marcelosalloum force-pushed the fix/support-XLM-in-integration-tests branch from df7fcff to 95a0b0c Compare November 27, 2024 20:37
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests November 27, 2024 20:37 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 27, 2024 20:37 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr470.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr470.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr470.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum merged commit 1d25834 into develop Nov 27, 2024
13 checks passed
@marcelosalloum marcelosalloum deleted the fix/support-XLM-in-integration-tests branch November 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwen-abid marwen-abid marwen-abid approved these changes

Assignees

@marcelosalloum marcelosalloum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelosalloum @stellar-jenkins @marwen-abid