Skip whitespace in base64 encoded inputs given to the CLI #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Skip whitespace in base64 encoded inputs given to the CLI.
Why
It's easy for spaces and new lines to end up in base64 inputs either because folks copy a base64 input and the following new line, or they pipe a value using
echowithout the-n, or they pipe a value from another command line tool that appends a new line, or they copy a base64 value that has been hard wrapped.There's not really any reason to fail parsing these inputs in the CLI. The CLI is intended to be convenient to use by humans.
Note that I considered making this change to the base64 decoder in the XDR library itself, but I think this convenience feature is most impactful and meaningful to users when they are interacting with the CLI, and to introduce this into other places like the XDR lib is likely to not be impactful or if it is in a surprising way.
Close #375