Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen ux improvements #1581

Open
wants to merge 2 commits into
base: feature/fullscreen-btn
Choose a base branch
from

Conversation

piyalbasu
Copy link
Contributor

@piyalbasu piyalbasu commented Oct 25, 2024

For users in full screen mode, they run the risk of leaving Freighter open in a tab for long periods of time (previously impossible). This can lead to a couple of issues:

  1. They are at risk of having stale data as we only fetch account balances when the app starts
  2. They could potentially leave the window open and forget about it, allowing a bad actor to get access to their account(s)

To help mitigate issue 1, I am showing a notification to the user that they might have stale data after a period of time and will need to reload. The real solution is to implement streaming or polling to keep the app up to date, but that is a bigger ticket and I think should come in an iterative follow up.

For 2, when the user is in full screen mode, we should log out accounts that are inactive, similar to any banking app. This inactivity check is only enabled when the user is in fullscreen mode. The inactivity timer resets when a user navigates to a different page. In the demo video below, I set the timer to be 10 seconds to illustrate the UX. Once the user stops navigating, the app waits 10 seconds and then logs them out. In real life, they would be something like 20 minutes.

@piyalbasu
Copy link
Contributor Author

Screen.Recording.2024-10-25.at.5.11.59.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant