[FEATURE] makes getIsToken spec return false if spec is not parseable #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
|
@piyalbasu I had to split up the helpers into 2 new files (network & token) in order to be able to mock the internals for the new test with Jest. In es6 it can only mock if the internal is imported so when they are in the same file this becomes harder. I just re-export them from the root of that dir now to allow the exports across the app to not change. |
piyalbasu
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes
getIsTokenSpecreturn false if it fails to parse the spec, because in this case it should be safe to assume that the contract is not a token.Why
getIsTokenSpeccan be more strict about asserting if a contract is a sep41 implementation.