This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Handle the fb_email_missing error #1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ | |||
| </div> | |||
|
|
|||
| <div ng-hide="reward.error"> | |||
| <div class="content" ng-class="{active: reward.status == 'incomplete' || reward.status == 'pending' || reward.status == 'unverified' || reward.status == 'ineligible' || reward.status == 'updated_too_recently'}"> | |||
| <div class="content" ng-class="{active: reward.status == 'incomplete' || reward.status == 'pending' || reward.status == 'unverified' || reward.status == 'ineligible' || reward.status == 'updated_too_recently' || reward.status == 'fb_email_missing'}"> | |||
There was a problem hiding this comment.
With the length of this, it seems like using {active: reward.error} would be preferable. Is there some reason not to?
There was a problem hiding this comment.
We definitely need to open an issue to look into this. This portion of the code base is way too complex. @bartekn is redesigning the rewards API and I expect most of this rewards code to get scrapped in the modular client, so it may not be worth the effort.
|
This code is being refactored in a different repo, as per deckar01's comment on Jan 21. Closing this PR as this effort will be applied elsewhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error messaging for the "fb_email_missing" state that occurs when a user does not have an email address associated with their facebook account.
Fixes #1136.