-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: dialog content screen overflow (#109)
If the screen gets small enough for the dialog content to overflow it, the content is not scrollable and the user has no chance to see all of it. This can easily happen on mobile with keyboard open. The solution I chose is to limit the height to viewport height and let the browser handle the overflow by showing a scrollbar.
- Loading branch information
Showing
2 changed files
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"solidui-cli": patch | ||
--- | ||
|
||
It makes dialog content vertically scrollable should it overflow the vertical space given by the viewport. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters