feat: add C ndarray API and refactor blas/ext/base/sapx
#4696
+401
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
stdlib-bot
added
the
BLAS
Coverage Report
The above coverage report was generated for the changes in this PR. |
headlessNode
commented
Jan 11, 2025
Comment on lines
99
to
106
| ```javascript | ||
| var Float32Array = require( '@stdlib/array/float32' ); | ||
|
|
||
| var x = new Float32Array( [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ] ); | ||
|
|
||
| sapx.ndarray( 3, 5.0, x, 1, x.length-3 ); | ||
| // x => <Float32Array>[ 1.0, -2.0, 3.0, 1.0, 10.0, -1.0 ] | ||
| // x => <Float32Array>[ 6.0, 3.0, 8.0, -4.0, 5.0, -6.0 ] | ||
| ``` |
There was a problem hiding this comment.
@kgryte Here I was getting a lint error which prevented me from pushing. I made this change to be able to push the commit.
I tried finding the cause but couldn't find any. The tests are passing, I also checked by changing the example in examples/index.js, the offset parameter worked there correctly. But for some reason here it is not working as expected. Any insights?
EDIT: The CI failure errors are the opposite of the errors I was getting in Local
Comment on lines
29
to
45
| * Adds a scalar constant to each element in a single-precision floating-point strided array. | ||
| * | ||
| * @param {PositiveInteger} N - number of indexed elements | ||
| * @param {number} alpha - scalar | ||
| * @param {number} alpha - scalar constant | ||
| * @param {Float32Array} x - input array | ||
| * @param {integer} stride - index increment | ||
| * @param {NonNegativeInteger} offset - starting index | ||
| * @param {integer} strideX - stride length | ||
| * @param {NonNegativeInteger} offsetX - starting index | ||
| * @returns {Float32Array} input array | ||
| * | ||
| * @example | ||
| * var Float32Array = require( '@stdlib/array/float32' ); | ||
| * | ||
| * var x = new Float32Array( [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ] ); | ||
| * var alpha = 5.0; | ||
| * | ||
| * sapx( 3, alpha, x, 1, x.length-3 ); | ||
| * // x => <Float32Array>[ 1.0, -2.0, 3.0, 1.0, 10.0, -1.0 ] | ||
| * sapx( 3, 5.0, x, 1, x.length-3 ); | ||
| * // x => <Float32Array>[ 6.0, 3.0, 8.0, -4.0, 5.0, -6.0 ] | ||
| */ |
There was a problem hiding this comment.
same comment here. Notice that the doctest for ndarray.js passses but for ndarray.native.js it fails.
headlessNode
added
Feature
headlessNode
commented
Jan 11, 2025
lib/node_modules/@stdlib/blas/ext/base/sapx/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Muhammad Haris <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
ndarrayAPI and refactor `blase/ext/base/sapxRelated Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers