Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor blas/ext/base/dcusumors to follow current project conventions #2041

Merged
merged 12 commits into from
Mar 26, 2024
Merged

refactor blas/ext/base/dcusumors to follow current project conventions #2041

merged 12 commits into from
Mar 26, 2024

Conversation

itskdhere
Copy link
Contributor

Resolves #1474 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors and updates the existing implementation of blas/ext/base/dcusumors to follow the current project conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 25, 2024
Pranavchiku
Pranavchiku suggested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, thanks for working on this!

@Pranavchiku Pranavchiku added Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged. labels Mar 26, 2024
@itskdhere
Copy link
Contributor Author

@Pranavchiku I've applied suggested changes. please take a look.

Planeshifter
Planeshifter approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge after CI has passed.

@Planeshifter Planeshifter merged commit d56c235 into stdlib-js:develop Mar 26, 2024
8 checks passed
@itskdhere itskdhere mentioned this pull request Mar 28, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku requested changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dcusumors to follow current project conventions
4 participants
@itskdhere @Planeshifter @Pranavchiku @stdlib-bot