Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add changeset status step to CI workflow #607

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Oct 11, 2024

Important

Measure impact of 8ecea95 before merging.

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: c67a9ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
status-components ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 0:57am

@status-im-auto
Copy link
Member

status-im-auto commented Oct 11, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 003d50e7 #1 2024-10-11 09:56:42 ~31 sec chrome 📦zip
✔️ 1b06ed6e #2 2024-10-11 13:28:14 ~28 sec chrome 📦zip
✔️ a75c2cf8 #3 2024-10-11 13:36:39 ~28 sec chrome 📦zip
✔️ 174e80ba #4 2024-10-11 13:49:06 ~30 sec chrome 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8ecea95 #7 2024-10-17 08:30:44 ~30 sec chrome 📦zip
✔️ ac5f149 #8 2025-01-07 11:49:24 ~32 sec chrome 📦zip

Copy link
Collaborator

@marcelines marcelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems to do the trick. Thanks for this.
image

Comment on lines -25 to +26
fetch-depth: 2
# https://github.com/changesets/changesets/issues/1055
fetch-depth: 0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm looking at it right, I'm seeing a difference only in couple seconds for "Check out code" https://github.com/status-im/status-web/actions/runs/11293559287/job/31411965124?pr=607 in comparison to other workflow runs https://github.com/status-im/status-web/actions.

@felicio felicio requested review from a team, jkbktl and prichodko January 7, 2025 11:42
@felicio felicio merged commit b286ef2 into main Jan 8, 2025
6 checks passed
@felicio felicio deleted the felicio/changeset-check branch January 8, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants