fix(wallet)_: Assets unsupported for bridge appear as disabled on swap flow #22007
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohamedjavid
requested review from
alwx,
shivekkhurana,
vkjr and
briansztamfater
Jenkins Builds
|
Signed-off-by: Mohamed Javid <[email protected]>
smohamedjavid
force-pushed
the
fix/clean-send-data-on-entering-swap-flow
branch
from
5599ac6 to
7985659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21959
Summary
This PR fixes assets unsupported for bridge appear as disabled on swap flow.
Review notes
The bug is caused by leftover data (
:tx-type) in app-db when the user leaves the bridge flow. We can add clean-up on the un-mount of those pages, but it will be time-consuming to identify as the user can enter from different entry points.Cleaning up the send data when entering the swap flow is much better.
Platforms
Steps to test
status: ready