You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows MixPanel to be configured per environment. The hardcoded MixPanel app ID and token are removed from the code (see the parent issue for more details). The token can be exploited and that's by design in analytics tools https://developer.mixpanel.com/reference/project-token, but we are being too kind at the same time, so I'm removing that from code ;)
Areas that may be impacted
Analytics
Steps to test
I will test this PR myself.
Enable usage data during onboarding and from settings.
Check the events are published to the correct MixPanel project.
Note: to test the correct values are set-up in Jenkins for release builds we need to generate a release build. That's the reason I committed a change to the VERSION file with the PR number, as I believe this is the recommendation from infra team.
@siddarthkay I tagged you as a reviewer to help us configure the vars in Jenkins. The shadow-cljs code already allows passing the vars to the initialization code in status-go, so I believe it's just a matter of passing down the vars from Jenkins. The parent issue has the details about what we expect to be configured #21974 in Jenkins. When the time is appropriate for you, could you help us by adding the vars to Jenkins? Thanks!
Device 1: Find `Button` by `accessibility id`: `network-dropdown`
Device 1: Tap on found: Button
critical/test_wallet.py:260: in test_wallet_balance_mainnet
self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
For the Ether the wrong value 0.0062 is shown, expected 0.0052 in total
E For the Status the wrong value 13.0 is shown, expected 10.0 in total
E For the Ether the wrong value 0.0011 is shown, expected 0.0001 on Optimism
E For the Status the wrong value 3.0 is shown, expected 0 on Optimism
Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]
Device 1: Element EmojisNumber text is equal to 1
critical/chats/test_public_chat_browsing.py:380: in test_community_message_edit
self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
Message is not edited
@siddarthkay, please let me know when you have set up the CI with the vars MIXPANEL_APP_ID and MIXPANEL_TOKEN so I can proceed with testing this PR. Thank you 🦾
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21974
Summary
Allows MixPanel to be configured per environment. The hardcoded MixPanel app ID and token are removed from the code (see the parent issue for more details). The token can be exploited and that's by design in analytics tools https://developer.mixpanel.com/reference/project-token, but we are being too kind at the same time, so I'm removing that from code ;)
Areas that may be impacted
Steps to test
I will test this PR myself.
Note: to test the correct values are set-up in Jenkins for release builds we need to generate a release build. That's the reason I committed a change to the
VERSION
file with the PR number, as I believe this is the recommendation from infra team.status: ready