fix: resolve UI glitches for chat, contacts, and keycard #21946

seanstrom · 2025-01-17T08:27:55Z

fixes #21477
fixes #21911

Summary

This PR attempts to resolve some UI glitches related to group-chat system messages, contact nickname editing, the disclaimer text for the keycard migration flow.
- I came across the edit-nickname drawer not having the correct drawer title, it was "Add nickname" instead of "Edit nickname".

Platforms

Android
iOS

Areas that may be impacted

Functional

group chats
edit contact nickname
disclaimer text for keycard flow

Steps to test

Edit contact nickname title

Open Status app
Open a contact, add a nickname, edit a nickname

Group chat system messages

Reproduction steps mentioned here: #21477

Keycard confirm backup-phrase disclaimer text

Reproduction steps mentioned here: #21911

Screenshots of Changes


Edit contact nickname drawer title
Group chat system messages
Keycard confirm backup phrase disclaimer text

status: ready

status-im-auto · 2025-01-17T08:33:20Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`70659f3`	#1	2025-01-17 08:33:19	~5 min	`tests`	📄`log`
✔️	`70659f3`	#1	2025-01-17 08:35:25	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`70659f3`	#1	2025-01-17 08:36:54	~8 min	`android`	🤖`apk` 📲
✔️	`70659f3`	#1	2025-01-17 08:38:50	~10 min	`ios`	📱`ipa` 📲

✔️	`e220bc9`	#2	2025-01-18 06:03:57	~5 min	`tests`	📄`log`
✔️	`e220bc9`	#2	2025-01-18 06:06:14	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`e220bc9`	#2	2025-01-18 06:06:46	~8 min	`android`	🤖`apk` 📲
✔️	`e220bc9`	#2	2025-01-18 06:08:25	~10 min	`ios`	📱`ipa` 📲

✔️	`30273b0`	#3	2025-01-20 14:16:46	~4 min	`tests`	📄`log`
✔️	`30273b0`	#3	2025-01-20 14:20:06	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`30273b0`	#3	2025-01-20 14:20:38	~8 min	`android`	🤖`apk` 📲
✔️	`30273b0`	#3	2025-01-20 14:22:36	~10 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`cf2994f`	#4	2025-01-22 14:16:38	~5 min	`tests`	📄`log`
✔️	`cf2994f`	#4	2025-01-22 14:19:41	~8 min	`android`	🤖`apk` 📲
✔️	`cf2994f`	#4	2025-01-22 14:20:05	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`cf2994f`	#4	2025-01-22 14:25:45	~14 min	`ios`	📱`ipa` 📲

✔️	`0d031f0`	#5	2025-01-23 09:29:57	~4 min	`tests`	📄`log`
✔️	`0d031f0`	#5	2025-01-23 09:33:05	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0d031f0`	#5	2025-01-23 09:33:36	~8 min	`android`	🤖`apk` 📲

status-im-auto · 2025-01-18T06:12:40Z

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7

IDs of failed tests: 702843

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device 1: Wait for text element `EmojisNumber` to be equal to `1` Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` `critical/chats/test_public_chat_browsing.py:380: in test_community_message_edit self.errors.verify_no_errors() base_test_case.py:176: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message reaction is not shown for the sender` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Passed tests (7)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

mariia-skrypnyk · 2025-01-22T10:53:42Z

Tested:

fixes [Android] The system message does not wrap to the next line if it's too long in a group chat #21477 (Android/iOS)
fixes [iOS] Text exceeds the boarder of Confirmation backup drawer #21911

seanstrom · 2025-01-22T14:36:01Z

@mariia-skrypnyk I've rebased this PR and tried manually testing issue #21911 on the Status-PR app, and the issue seems to be fixed since the text is no longer exceeding the boundary. Are you seeing different results? If so, can you share your device details please. 🙏

…ntainer layout

mariia-skrypnyk · 2025-01-23T10:12:39Z

Hi @seanstrom !

Thanks for your brilliant fixes.
Those check-boxes were my notes what was tested and what I was working on.
No issues there.
I will rerun tests and let you know.

status-im-auto · 2025-01-23T10:27:06Z

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6

IDs of failed tests: 702745,702843

Failed tests (2)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 7.25724230664488 percents `critical/chats/test_1_1_public_chats.py:323: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:176: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 2: Click until Button by accessibility id: close-activity-center will be presented
Device 2: Find Button by accessibility id: open-activity-center-button

Test setup failed: critical/chats/test_public_chat_browsing.py:318: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:383: in handle_contact_request
    self.open_activity_center_button.click_until_presence_of_element(self.close_activity_centre)
../views/base_element.py:106: in click_until_presence_of_element
    self.find_element().click()
../views/base_element.py:78: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `open-activity-center-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Passed tests (6)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

status-im-auto · 2025-01-23T12:19:38Z

100% of end-end tests have passed

Total executed tests: 2
Failed tests: 0
Expected to fail tests: 0
Passed tests: 2

Passed tests (2)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2025-01-23T12:30:17Z

@seanstrom e2e are 👌
PR can be merged!

seanstrom added the mobile-core label Jan 17, 2025

seanstrom self-assigned this Jan 17, 2025

seanstrom requested review from ilmotta, Parveshdhull and ulisesmac January 17, 2025 08:28

Parveshdhull approved these changes Jan 17, 2025

View reviewed changes

ilmotta approved these changes Jan 17, 2025

View reviewed changes

ulisesmac approved these changes Jan 18, 2025

View reviewed changes

seanstrom force-pushed the seanstrom/fix-ui-glitches branch from 70659f3 to e220bc9 Compare January 18, 2025 05:57

seanstrom force-pushed the seanstrom/fix-ui-glitches branch from e220bc9 to 30273b0 Compare January 20, 2025 14:12

mariia-skrypnyk self-assigned this Jan 21, 2025

pavloburykh added the request-manual-qa label Jan 21, 2025

seanstrom force-pushed the seanstrom/fix-ui-glitches branch from 30273b0 to cf2994f Compare January 22, 2025 14:11

seanstrom added 3 commits January 23, 2025 09:25

fix: ensure disclaimer text will wrap based on container layout

9162bf1

fix: ensure we use the edit-nickname title when editing nickname

53abbfd

fix: ensure chat system-messages for group chat will wrap based on co…

0d031f0

…ntainer layout

seanstrom force-pushed the seanstrom/fix-ui-glitches branch from cf2994f to 0d031f0 Compare January 23, 2025 09:25

mariia-skrypnyk added the Tested - OK label Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve UI glitches for chat, contacts, and keycard #21946

fix: resolve UI glitches for chat, contacts, and keycard #21946

seanstrom commented Jan 17, 2025

status-im-auto commented Jan 17, 2025 •

edited

Loading

status-im-auto commented Jan 18, 2025

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

mariia-skrypnyk commented Jan 22, 2025 •

edited

Loading

seanstrom commented Jan 22, 2025

mariia-skrypnyk commented Jan 23, 2025

status-im-auto commented Jan 23, 2025

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

status-im-auto commented Jan 23, 2025

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

mariia-skrypnyk commented Jan 23, 2025

fix: resolve UI glitches for chat, contacts, and keycard #21946

Are you sure you want to change the base?

fix: resolve UI glitches for chat, contacts, and keycard #21946

Conversation

seanstrom commented Jan 17, 2025

Summary

Platforms

Areas that may be impacted

Functional

Steps to test

Edit contact nickname title

Group chat system messages

Keycard confirm backup-phrase disclaimer text

Screenshots of Changes

status-im-auto commented Jan 17, 2025 • edited Loading

Jenkins Builds

status-im-auto commented Jan 18, 2025

88% of end-end tests have passed

Failed tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

mariia-skrypnyk commented Jan 22, 2025 • edited Loading

seanstrom commented Jan 22, 2025

mariia-skrypnyk commented Jan 23, 2025

status-im-auto commented Jan 23, 2025

75% of end-end tests have passed

Failed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (6)

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

status-im-auto commented Jan 23, 2025

100% of end-end tests have passed

Passed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

mariia-skrypnyk commented Jan 23, 2025

status-im-auto commented Jan 17, 2025 •

edited

Loading

mariia-skrypnyk commented Jan 22, 2025 •

edited

Loading