deps: bump react-native-linear-gradient library #20329

siddarthkay · 2024-06-05T05:49:21Z

Summary

react-native-linear-gradient library has to be upgraded to 3.0.0-alpha.1 for new architecture support on Android.

Testing notes

Only visual elements where gradients are used would be impacted.

Platforms

Android
iOS

status: ready

related issue : #18138

status-im-auto · 2024-06-05T05:53:55Z

Jenkins Builds

Click to see older builds (27)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`e9e4822`	#1	2024-06-05 05:53:54	~4 min	`android-e2e`	📄`log`
❌	`e9e4822`	#1	2024-06-05 05:54:43	~5 min	`android`	📄`log`
✔️	`e9e4822`	#1	2024-06-05 05:55:07	~5 min	`tests`	📄`log`
✔️	`e9e4822`	#1	2024-06-05 06:00:16	~10 min	`ios`	📱`ipa` 📲

❌	`c55f702`	#2	2024-06-05 07:00:45	~2 min	`android`	📄`log`
❌	`c55f702`	#2	2024-06-05 07:00:59	~3 min	`android-e2e`	📄`log`
✔️	`c55f702`	#2	2024-06-05 07:02:02	~4 min	`tests`	📄`log`
✔️	`c55f702`	#2	2024-06-05 07:06:46	~8 min	`ios`	📱`ipa` 📲

✔️	`f4ff863`	#3	2024-06-05 07:43:27	~4 min	`tests`	📄`log`
✔️	`f4ff863`	#3	2024-06-05 07:46:12	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`f4ff863`	#3	2024-06-05 07:46:19	~7 min	`android`	🤖`apk` 📲

✔️	`9b0f036`	#4	2024-06-05 07:52:36	~4 min	`tests`	📄`log`
✔️	`9b0f036`	#4	2024-06-05 07:55:39	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`9b0f036`	#4	2024-06-05 07:55:39	~7 min	`android`	🤖`apk` 📲
✔️	`9b0f036`	#4	2024-06-05 07:59:56	~11 min	`ios`	📱`ipa` 📲

✔️	`c978947`	#6	2024-06-07 11:50:07	~5 min	`tests`	📄`log`
✔️	`c978947`	#6	2024-06-07 11:52:27	~8 min	`android`	🤖`apk` 📲
✔️	`c978947`	#6	2024-06-07 11:52:37	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`c978947`	#6	2024-06-07 11:58:37	~14 min	`ios`	📱`ipa` 📲

✔️	`dcc6f7e`	#7	2024-06-07 12:40:12	~5 min	`tests`	📄`log`
✔️	`dcc6f7e`	#7	2024-06-07 12:40:53	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`dcc6f7e`	#7	2024-06-07 12:42:10	~7 min	`android`	🤖`apk` 📲
✔️	`dcc6f7e`	#7	2024-06-07 12:43:31	~9 min	`ios`	📱`ipa` 📲

✔️	`1bd6365`	#8	2024-06-10 06:50:20	~4 min	`tests`	📄`log`
✔️	`1bd6365`	#8	2024-06-10 06:53:13	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`1bd6365`	#8	2024-06-10 06:53:21	~7 min	`android`	🤖`apk` 📲
✔️	`1bd6365`	#8	2024-06-10 06:55:28	~9 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`cf297cb`	#9	2024-06-11 13:02:57	~4 min	`tests`	📄`log`
✔️	`cf297cb`	#9	2024-06-11 13:06:04	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`cf297cb`	#9	2024-06-11 13:06:09	~7 min	`android`	🤖`apk` 📲
✔️	`cf297cb`	#9	2024-06-11 13:07:46	~8 min	`ios`	📱`ipa` 📲

✔️	`0a56850`	#10	2024-06-12 08:06:37	~4 min	`tests`	📄`log`
✔️	`0a56850`	#10	2024-06-12 08:09:45	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0a56850`	#10	2024-06-12 08:09:50	~7 min	`android`	🤖`apk` 📲
✔️	`0a56850`	#10	2024-06-12 08:11:38	~9 min	`ios`	📱`ipa` 📲

status-im-auto · 2024-06-05T08:26:05Z

84% of end-end tests have passed

Total executed tests: 51
Failed tests: 5
Expected to fail tests: 3
Passed tests: 43
Not executed tests: 1

IDs of not executed tests: 702936

IDs of failed tests: 727230,727229,703202,703391,702958

IDs of expected to fail tests: 703495,703503,727232

Not executed tests (1)

Click to expand

Rerun not executed tests

Failed tests (5)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202

Device 1: Find `Button` by `accessibility id`: `authors-for-reaction-5`
Device 1: Tap on found: Button

critical/chats/test_group_chat.py:213: in test_group_chat_reactions
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect reactions count for member_1 after changing the reactions

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_send_image_save_and_share, id: 703391

Device 1: Tap on found: Button
Device 1: Find BaseElement by accessibility id: toast-content

critical/chats/test_1_1_public_chats.py:447: in test_1_1_chat_send_image_save_and_share
    toast_element_text = toast_element.text
../views/base_element.py:237: in text
    return self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: BaseElement by accessibility id: `toast-content` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958

Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
Device 2: Wait for element Button for max 120s and click when it is available

activity_center/test_activity_center.py:474: in test_activity_center_admin_notification_accept_swipe
    self.community_2.join_community(open_community=False)
../views/chat_view.py:420: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
# STEP: Getting ETH amount in the wallet of the sender before transaction Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` critical/test_wallet.py:120: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:41: in _get_balances_before_tx self.wallet_1.wallet_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Tap on found: LogInButton Device 1: Find `Button` by `accessibility id`: `done` critical/test_wallet.py:111: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:100: in send_asset self.confirm_transaction() ../views/wallet_view.py:88: in confirm_transaction self.done_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Expected to fail tests (3)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
Device 1: Click system back button

critical/test_wallet.py:214: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (43)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

siddarthkay · 2024-06-10T06:57:14Z

@status-im/mobile-qa : Actually this PR just requires a design review since this library upgrade could probably have an impact on how gradients are rendered or how they look.
cc @Francesca-G

churik · 2024-06-10T08:47:57Z

@Francesca-G if you can point us to the places in the app where gradients are used, it would be really helpful!!!

Francesca-G · 2024-06-10T13:36:15Z

@Francesca-G if you can point us to the places in the app where gradients are used, it would be really helpful!!!

Wallet:

Send and Bridge

Wallet account

Share QR

Messages:

Group details and new group chat

Communities:

Community cover

Channel details

That should be it, hopefully I'm not forgetting anything 🙈

qoqobolo · 2024-06-11T10:10:32Z

Another one: account switcher in wallet

qoqobolo · 2024-06-11T12:56:57Z

Thanks @siddarthkay @Francesca-G!
No issues found, PR is ready for design review

Francesca-G

Looks good to me 🚀

`react-native-linear-gradient` library has to be upgraded to `3.0.0-alpha.1` for new architecture support on `Android`.

siddarthkay · 2024-06-12T08:03:53Z

Thanks @qoqobolo and @Francesca-G for taking a look :)

siddarthkay self-assigned this Jun 5, 2024

siddarthkay requested a review from jakubgs as a code owner June 5, 2024 05:49

siddarthkay mentioned this pull request Jun 5, 2024

research for enabling new architecture in react-native #18138

Open

7 tasks

siddarthkay force-pushed the bump-react-native-linear-gradient branch from c55f702 to f4ff863 Compare June 5, 2024 07:38

siddarthkay force-pushed the bump-react-native-linear-gradient branch from f4ff863 to 9b0f036 Compare June 5, 2024 07:48

siddarthkay added the request-manual-qa label Jun 5, 2024

siddarthkay requested a review from a team June 5, 2024 07:48

flexsurfer approved these changes Jun 5, 2024

View reviewed changes

clauxx approved these changes Jun 5, 2024

View reviewed changes

Parveshdhull approved these changes Jun 5, 2024

View reviewed changes

siddarthkay force-pushed the bump-react-native-linear-gradient branch 2 times, most recently from 1d9e5a8 to c978947 Compare June 7, 2024 11:44

siddarthkay force-pushed the bump-react-native-linear-gradient branch from c978947 to dcc6f7e Compare June 7, 2024 12:34

ilmotta approved these changes Jun 7, 2024

View reviewed changes

siddarthkay force-pushed the bump-react-native-linear-gradient branch from dcc6f7e to 1bd6365 Compare June 10, 2024 06:45

churik added the design-review-required label Jun 10, 2024

qoqobolo self-assigned this Jun 11, 2024

qoqobolo added the Tested - OK label Jun 11, 2024

siddarthkay force-pushed the bump-react-native-linear-gradient branch from 1bd6365 to cf297cb Compare June 11, 2024 12:58

Francesca-G approved these changes Jun 12, 2024

View reviewed changes

deps: bump react-native-linear-gradient library

0a56850

`react-native-linear-gradient` library has to be upgraded to `3.0.0-alpha.1` for new architecture support on `Android`.

siddarthkay force-pushed the bump-react-native-linear-gradient branch from cf297cb to 0a56850 Compare June 12, 2024 08:02

siddarthkay merged commit 672358f into develop Jun 12, 2024
6 checks passed

siddarthkay deleted the bump-react-native-linear-gradient branch June 12, 2024 08:13

yakimant mentioned this pull request Jun 24, 2024

Remove useless PR checks status-im/status-go#5337

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: bump react-native-linear-gradient library #20329

deps: bump react-native-linear-gradient library #20329

siddarthkay commented Jun 5, 2024 •

edited

Loading

status-im-auto commented Jun 5, 2024 •

edited

Loading

status-im-auto commented Jun 5, 2024

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestWalletOneDevice:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

siddarthkay commented Jun 10, 2024

churik commented Jun 10, 2024

Francesca-G commented Jun 10, 2024

qoqobolo commented Jun 11, 2024 •

edited

Loading

qoqobolo commented Jun 11, 2024

Francesca-G left a comment

siddarthkay commented Jun 12, 2024

deps: bump react-native-linear-gradient library #20329

deps: bump react-native-linear-gradient library #20329

Conversation

siddarthkay commented Jun 5, 2024 • edited Loading

Summary

Testing notes

Platforms

status-im-auto commented Jun 5, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Jun 5, 2024

84% of end-end tests have passed

Not executed tests (1)

Failed tests (5)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestWalletMultipleDevice:

Expected to fail tests (3)

Class TestWalletOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Passed tests (43)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestWalletOneDevice:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

siddarthkay commented Jun 10, 2024

churik commented Jun 10, 2024

Francesca-G commented Jun 10, 2024

qoqobolo commented Jun 11, 2024 • edited Loading

qoqobolo commented Jun 11, 2024

Francesca-G left a comment

Choose a reason for hiding this comment

siddarthkay commented Jun 12, 2024

siddarthkay commented Jun 5, 2024 •

edited

Loading

status-im-auto commented Jun 5, 2024 •

edited

Loading

qoqobolo commented Jun 11, 2024 •

edited

Loading