Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade react-native-permissions library #19695

Merged
merged 1 commit into from
Apr 22, 2024
Merged

upgrade react-native-permissions library #19695

merged 1 commit into from
Apr 22, 2024

Conversation

siddarthkay
Copy link
Contributor

Summary

This PR upgrades react-native-permissions library to latest version 4.1.5

needed for : #18138

Review & Test notes

Please test permissions related flows on onboarding, selecting images, notifications and any other areas you can think of.

Platforms

  • iOS
  • Android

status: ready

@siddarthkay siddarthkay self-assigned this Apr 17, 2024
@siddarthkay siddarthkay force-pushed the bump-react-native-permissions-lib branch from 785c78a to af5f744 Compare April 17, 2024 14:23
@siddarthkay siddarthkay mentioned this pull request Apr 17, 2024
Open
7 tasks
@siddarthkay siddarthkay requested review from jakubgs and a team April 17, 2024 14:30
@status-im-auto
Copy link
Member

status-im-auto commented Apr 17, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ af5f744 #2 2024-04-17 14:35:17 ~11 min tests 📄log
✔️ af5f744 #2 2024-04-17 14:37:06 ~13 min android-e2e 🤖apk 📲
✔️ af5f744 #2 2024-04-17 14:37:31 ~13 min android 🤖apk 📲
✔️ af5f744 #2 2024-04-17 14:42:12 ~18 min ios 📱ipa 📲
✔️ 5d8747d #4 2024-04-18 07:59:04 ~5 min tests 📄log
✔️ 5d8747d #5 2024-04-18 08:02:19 ~8 min android-e2e 🤖apk 📲
✔️ 5d8747d #5 2024-04-18 08:03:57 ~10 min android 🤖apk 📲
✔️ 5d8747d #5 2024-04-18 08:08:17 ~14 min ios 📱ipa 📲
✔️ 3e76860 #6 2024-04-18 09:11:30 ~8 min android-e2e 🤖apk 📲
✔️ 3e76860 #5 2024-04-18 09:12:37 ~9 min tests 📄log
✔️ 3e76860 #6 2024-04-18 09:14:26 ~11 min android 🤖apk 📲
✔️ 3e76860 #6 2024-04-18 09:20:56 ~18 min ios 📱ipa 📲
✔️ 52fc215 #6 2024-04-19 08:31:06 ~5 min tests 📄log
✔️ 52fc215 #7 2024-04-19 08:31:58 ~6 min android-e2e 🤖apk 📲
✔️ 52fc215 #7 2024-04-19 08:32:08 ~6 min android 🤖apk 📲
✔️ 52fc215 #7 2024-04-19 08:38:20 ~12 min ios 📱ipa 📲
✔️ d64e1c7 #7 2024-04-19 14:45:31 ~4 min tests 📄log
✔️ d64e1c7 #8 2024-04-19 14:49:02 ~8 min android-e2e 🤖apk 📲
✔️ d64e1c7 #8 2024-04-19 14:49:09 ~8 min android 🤖apk 📲
✔️ d64e1c7 #8 2024-04-19 14:52:33 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ c77aad0 #8 2024-04-22 15:26:56 ~6 min tests 📄log
✔️ c77aad0 #9 2024-04-22 15:30:29 ~10 min ios 📱ipa 📲
✔️ c77aad0 #9 2024-04-22 15:33:42 ~13 min android-e2e 🤖apk 📲
✔️ c77aad0 #9 2024-04-22 15:34:00 ~13 min android 🤖apk 📲
✔️ 90b8f6a #9 2024-04-22 15:54:03 ~4 min tests 📄log
✔️ 90b8f6a #10 2024-04-22 15:55:47 ~6 min android 🤖apk 📲
✔️ 90b8f6a #10 2024-04-22 15:57:58 ~8 min ios 📱ipa 📲
✔️ 90b8f6a #10 2024-04-22 16:00:43 ~11 min android-e2e 🤖apk 📲

@siddarthkay siddarthkay force-pushed the bump-react-native-permissions-lib branch 3 times, most recently from b810f0a to 5d8747d Compare April 18, 2024 07:53
@siddarthkay
Copy link
Contributor Author

@status-im/mobile-qa : Please smoke check this PR with respect to permission related flows, we only upgrade the permissions library to the latest.
May impact both Android & iOS.

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 2
Expected to fail tests: 2
Passed tests: 48

IDs of failed tests: 727230,727229 

IDs of expected to fail tests: 703503,703495

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 1: `Text` is `0.05573 ETH` 

    critical/test_wallet.py:126: in test_wallet_send_asset_from_drawer
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:97: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the receivers wallet is 0.0201 but should be 0.0202
E    Eth amount in the senders wallet is 0.0557 but should be 0.0556



    Device sessions

    2. test_wallet_send_eth, id: 727229

    Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 1: Text is 0.05573 ETH 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:97: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the receivers wallet is 0.0201 but should be 0.0202
E    Eth amount in the senders wallet is 0.0557 but should be 0.0556



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (48)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @siddarthkay siddarthkay force-pushed the bump-react-native-permissions-lib branch from 5d8747d to 3e76860 Compare April 18, 2024 09:02
    @siddarthkay siddarthkay force-pushed the bump-react-native-permissions-lib branch from 3e76860 to 52fc215 Compare April 19, 2024 08:25
    @pavloburykh pavloburykh self-assigned this Apr 19, 2024
    @pavloburykh pavloburykh force-pushed the bump-react-native-permissions-lib branch from 52fc215 to d64e1c7 Compare April 19, 2024 14:40
    @pavloburykh
    Copy link
    Contributor

    @siddarthkay thanks for the PR. No issue from my side. Ready for merge.

    @siddarthkay siddarthkay force-pushed the bump-react-native-permissions-lib branch from d64e1c7 to c77aad0 Compare April 22, 2024 15:20
    @siddarthkay
    upgrade react-native-permissions library to 4.1.5
    90b8f6a 
    ## Summary

This commit upgrades `react-native-permissions` library to latest version 4.1.5

needed for : #18138

## Review & Test notes

Please test permissions related flows on onboarding, selecting images, notifications and any other areas you can think of.

## Platforms
- iOS
- Android

status: ready
    @siddarthkay siddarthkay force-pushed the bump-react-native-permissions-lib branch from c77aad0 to 90b8f6a Compare April 22, 2024 15:49
    @siddarthkay siddarthkay merged commit 9b2f614 into develop Apr 22, 2024
    6 checks passed
    @siddarthkay siddarthkay deleted the bump-react-native-permissions-lib branch April 22, 2024 16:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @jo-mut jo-mut jo-mut approved these changes

    @OmarBasem OmarBasem OmarBasem approved these changes

    @jakubgs jakubgs Awaiting requested review from jakubgs

    Assignees

    @siddarthkay siddarthkay

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @siddarthkay @status-im-auto @pavloburykh @ilmotta @jo-mut @OmarBasem