Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udp)_: fix for the TestUDPNotifier #6281

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

Samyoul
Copy link
Member

@Samyoul Samyoul commented Jan 23, 2025

In some cases the CI will discover only itself, this fix allows for the UDP test function to accept this circumstance.

@Samyoul Samyoul requested review from clauxx and a team January 23, 2025 17:42
@Samyoul Samyoul self-assigned this Jan 23, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 23, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8b84bbf #1 2025-01-23 17:46:19 ~3 min macos 📦zip
✔️ 8b84bbf #1 2025-01-23 17:46:27 ~3 min ios 📦zip
✔️ 8b84bbf #1 2025-01-23 17:48:03 ~5 min macos 📦zip
✔️ 8b84bbf #1 2025-01-23 17:48:08 ~5 min android 📦aar
✔️ 8b84bbf #1 2025-01-23 17:48:14 ~5 min linux 📦zip
✔️ 8b84bbf #1 2025-01-23 17:48:42 ~5 min windows 📦zip
✔️ 8b84bbf #1 2025-01-23 17:49:19 ~6 min tests-rpc 📄log
✖️ 8b84bbf #1 2025-01-23 18:13:19 ~30 min tests 📄log
✔️ 97bb360 #2 2025-01-24 10:26:10 ~3 min macos 📦zip
✔️ 97bb360 #2 2025-01-24 10:26:44 ~3 min windows 📦zip
✔️ 97bb360 #2 2025-01-24 10:27:02 ~4 min ios 📦zip
✔️ 97bb360 #2 2025-01-24 10:28:10 ~5 min linux 📦zip
✔️ 97bb360 #2 2025-01-24 10:28:45 ~6 min android 📦aar
✔️ 97bb360 #2 2025-01-24 10:28:56 ~6 min tests-rpc 📄log
✔️ 97bb360 #2 2025-01-24 10:29:10 ~6 min macos 📦zip
✔️ 97bb360 #2 2025-01-24 10:53:19 ~30 min tests 📄log

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (5240da6) to head (97bb360).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6281      +/-   ##
===========================================
- Coverage    61.81%   61.78%   -0.03%     
===========================================
  Files          843      843              
  Lines       111286   111286              
===========================================
- Hits         68789    68758      -31     
- Misses       34521    34540      +19     
- Partials      7976     7988      +12     
Flag Coverage Δ
functional 21.54% <ø> (-0.02%) ⬇️
unit 60.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

@clauxx clauxx merged commit 7bb4cf1 into develop Jan 24, 2025
19 checks passed
@clauxx clauxx deleted the fix/udp-notifier-test branch January 24, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants