fix_: properly check type casts in activity service #6279
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samyoul
reviewed
Jan 23, 2025
Comment on lines
+328
to
+332
| } else if err == nil { | ||
| recipientsResponse, ok := result.(*GetRecipientsResponse) | ||
| if ok { | ||
| res = recipientsResponse | ||
| } |
There was a problem hiding this comment.
If err == nil and result can not be type asserted as * GetRecipientsResponse then this function will return :
&GetRecipientsResponse{
ErrorCode: ErrorCodeFailed,
}There was a problem hiding this comment.
that's fine, it's basically the same behavior you get from the other functions, since for some reason you don't have a valid result you can return.
igor-sirotin
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
@dlipicar is there a linter we can apply to prevent this in the future?
Samyoul
approved these changes
Jan 23, 2025
Jenkins Builds
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/status-im/least-authority-audit/issues/17
Properly check type cast validity before attempting to access it.