chore_: remove wakuv1 and wakuv2 wrappers

[osmaczko]

No description provided.

[status-im-auto]

Jenkins Builds

Click to see older builds (11)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	eab61cc	#1	2025-01-21 20:48:30	~4 min	macos	📦zip
✔️	eab61cc	#1	2025-01-21 20:48:38	~4 min	windows	📦zip
✔️	eab61cc	#1	2025-01-21 20:48:46	~4 min	ios	📦zip
✔️	eab61cc	#1	2025-01-21 20:49:35	~5 min	linux	📦zip
✔️	eab61cc	#1	2025-01-21 20:49:44	~5 min	android	📦aar
✔️	eab61cc	#1	2025-01-21 20:49:55	~5 min	macos	📦zip
✔️	eab61cc	#1	2025-01-21 20:50:23	~6 min	tests-rpc	📄log
✖️	eab61cc	#1	2025-01-21 21:15:17	~31 min	tests	📄log
✔️	45fc2c6	#2	2025-01-21 20:51:30	~2 min	windows	📦zip
✔️	45fc2c6	#2	2025-01-21 20:52:44	~4 min	macos	📦zip
✔️	45fc2c6	#2	2025-01-21 20:53:24	~4 min	ios	📦zip

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	228d40b	#3	2025-01-21 20:54:25	~2 min	windows	📦zip
✔️	228d40b	#2	2025-01-21 20:54:26	~4 min	linux	📦zip
✔️	228d40b	#2	2025-01-21 20:55:17	~5 min	android	📦aar
✔️	228d40b	#2	2025-01-21 20:55:19	~5 min	macos	📦zip
✔️	228d40b	#2	2025-01-21 20:56:16	~5 min	tests-rpc	📄log
✔️	228d40b	#3	2025-01-21 20:57:06	~4 min	macos	📦zip
✔️	228d40b	#3	2025-01-21 20:58:03	~4 min	ios	📦zip
✖️	228d40b	#2	2025-01-21 21:46:00	~30 min	tests	📄log
✔️	c22db18	#4	2025-01-22 14:12:43	~2 min	windows	📦zip
✔️	c22db18	#4	2025-01-22 14:14:06	~4 min	macos	📦zip
✔️	c22db18	#4	2025-01-22 14:14:12	~4 min	ios	📦zip
✔️	c22db18	#3	2025-01-22 14:14:42	~5 min	linux	📦zip
✔️	c22db18	#3	2025-01-22 14:15:14	~5 min	macos	📦zip
✔️	c22db18	#3	2025-01-22 14:16:16	~6 min	tests-rpc	📄log
✔️	c22db18	#3	2025-01-22 14:16:48	~7 min	android	📦aar
✖️	c22db18	#3	2025-01-22 14:39:12	~29 min	tests	📄log
✔️	c22db18	#4	2025-01-22 15:32:58	~29 min	tests	📄log

[chaitanyaprem]

wondering if we need to keep wakuv1. since we are refactoring anyways, why not remove it and just have waku and use it directly. i am sure a lot of unused code will get deleted as well this way.
also wakuv1 is removed from underlying waku repo anyways already.

but @richard-ramos will have better idea than me on this topic though

[osmaczko]

wondering if we need to keep wakuv1. since we are refactoring anyways, why not remove it and just have waku and use it directly. i am sure a lot of unused code will get deleted as well this way. also wakuv1 is removed from underlying waku repo anyways already.

but @richard-ramos will have better idea than me on this topic though

This would be the next step, but it is not trivial because nearly all protocol tests depend on wakuv1.

[richard-ramos]

wondering if we need to keep wakuv1. since we are refactoring anyways, why not remove it and just have waku and use it directly. i am sure a lot of unused code will get deleted as well this way.
also wakuv1 is removed from underlying waku repo anyways already.

Ideally we'd remove it, yes. The annoying part is that some tests depend on a storenode that's created on the fly, so that means that some tests would need to be modified to use a nwaku node via docker.

[codecov]

Codecov Report

Attention: Patch coverage is 43.90244% with 184 lines in your changes missing coverage. Please review.

Project coverage is 61.79%. Comparing base (3e0b1b2) to head (c22db18).
Report is 13 commits behind head on develop.

Files with missing lines	Patch %	Lines
wakuv1/waku_unsupported.go	3.27%	59 Missing ⚠️
wakuv1/bridge.go	30.43%	47 Missing and 1 partial ⚠️
wakuv2/bridge.go	33.33%	26 Missing and 2 partials ⚠️
wakuv2/waku.go	80.95%	14 Missing and 2 partials ⚠️
wakuv1/waku.go	80.00%	5 Missing and 3 partials ⚠️
protocol/messenger_testing_utils.go	0.00%	6 Missing ⚠️
wakuv1/api.go	25.00%	6 Missing ⚠️
wakuv2/waku_unsupported.go	0.00%	4 Missing ⚠️
waku/types/topic.go	0.00%	3 Missing ⚠️
wakuv1/common/filter.go	0.00%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6273      +/-   ##
===========================================
- Coverage    61.92%   61.79%   -0.14%     
===========================================
  Files          843      840       -3     
  Lines       111286   111156     -130     
===========================================
- Hits         68918    68685     -233     
- Misses       34388    34499     +111     
+ Partials      7980     7972       -8     

Flag	Coverage Δ
functional	21.52% <25.00%> (-0.06%)	⬇️
unit	60.28% <43.29%> (-0.13%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
eth-node/bridge/geth/node.go	24.24% <100.00%> (ø)
mailserver/mailserver.go	36.32% <100.00%> (ø)
waku/types/waku.go	66.66% <ø> (ø)
wakuv1/common/filter.go	81.10% <0.00%> (-1.30%)	⬇️
wakuv2/api.go	38.26% <50.00%> (ø)
wakuv2/common/filter.go	71.63% <0.00%> (-0.32%)	⬇️
waku/types/topic.go	83.67% <0.00%> (-5.46%)	⬇️
wakuv2/waku_unsupported.go	0.00% <0.00%> (ø)
protocol/messenger_testing_utils.go	59.62% <0.00%> (-0.38%)	⬇️
wakuv1/api.go	36.29% <25.00%> (ø)
... and 5 more

... and 37 files with indirect coverage changes