fix_: check if bridge for token exists in ToChainId before returning contract address for FromChainId #6272
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
requested review from
alaibe,
shivekkhurana,
vkjr,
dlipicar,
smohamedjavid,
mohsen-ghafouri and
saledjenic
Jenkins BuildsClick to see older builds (33)
|
briansztamfater
force-pushed
the
fix/check-bridge-to-chain-id
branch
from
fb700ee to
d33b39e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6272 +/- ##
========================================
Coverage 61.82% 61.83%
========================================
Files 843 843
Lines 111286 111288 +2
========================================
+ Hits 68807 68815 +8
- Misses 34506 34507 +1
+ Partials 7973 7966 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
briansztamfater
force-pushed
the
fix/check-bridge-to-chain-id
branch
3 times, most recently
from
dd2988e to
85f3992
Compare
briansztamfater
changed the title
…contract address for FromChainId Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
fix/check-bridge-to-chain-id
branch
from
85f3992 to
661a31b
Compare
dlipicar
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Looks like a very nice catch! I'd like the expert @saledjenic to chime in before merging, to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Hop does not support some tokens on Base such as DAI or USDT, but the router returns a valid route for such transactions, ending on failed transactions and gas wasting for such cases.
This PR adds a check for the bridge contract receiving chain ID before returning the bridge contract for the sender chain ID, in that way we return an error if the token is not supported on Hop for the receiving chain ID.
We have an issue in status-mobile which this PR should partially fix it (proper fix would be to prevent the user to select unsupported tokens for selected chain): status-im/status-mobile#21964