chore_: move waku interface out of eth-node #6244
Conversation
osmaczko
requested review from
a team,
richard-ramos,
plopezlpz and
igor-sirotin
Jenkins BuildsClick to see older builds (8)
|
osmaczko
force-pushed
the
chore/whisper-cleanup
branch
from
5c78c3a to
6dc3ce7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6244 +/- ##
========================================
Coverage 61.55% 61.56%
========================================
Files 842 842
Lines 110604 110604
========================================
+ Hits 68086 68096 +10
- Misses 34562 34569 +7
+ Partials 7956 7939 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wakuinterface/api.go
Outdated
There was a problem hiding this comment.
I'm not sure if wakuinterface is a good naming. If it's always waku, then what's the point describing it as interface, we can use it directly, right?
Perhaps transport would be a better name?
wakuinterface/api.go
Outdated
There was a problem hiding this comment.
Recently I started to add new files into ./internal directory, as a step to follow Standard Go Project Layout.
Do you think we could do the same for this PR? It could maybe fall under ./pkg directory though, not sure.
There was a problem hiding this comment.
I will postpone using ./internal for now, if you don't mind. I plan to consolidate everything once I have resolved all the waku <-> eth-node dependencies.
There was a problem hiding this comment.
I like the idea of moving the waku interface out of eth-node but not the new name wakuinterface. I just wonder if we could instead rename the package waku to wakuv1 instead, and use waku instead of wakuinterface.
In any case, i'm approving it since the change is good, and my suggestion is just nitpicking :)
osmaczko
force-pushed
the
chore/whisper-cleanup
branch
from
6dc3ce7 to
572bc4f
Compare
Waku interface does not belong to eth-node. It has been moved to newly created
wakuinterfacepackage.