-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore_: remove endpoint InitLogging #6182
Conversation
Jenkins Builds
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6182 +/- ##
============================================
+ Coverage 13.90% 60.87% +46.97%
============================================
Files 817 832 +15
Lines 108323 109882 +1559
============================================
+ Hits 15065 66896 +51831
+ Misses 91338 35139 -56199
- Partials 1920 7847 +5927
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 👌
Technically, it is a breaking change and should be marked as such I believe.
If the desktop and mobile are no longer using this endpoint, it shouldn't be considered a breaking change, right? @osmaczko |
Not sure. From API point of view, removal is a breaking change. We shouldn't assume desktop and mobile already removed the endpoint usage. Moreover, theoretically, there might be more clients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because mobile PR and status-go PR have been merged,
InitLogging
should has no usage now, could you help check if desktop used it? @igor-sirotin