Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: remove endpoint InitLogging #6182

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Dec 9, 2024

Because mobile PR and status-go PR have been merged, InitLogging should has no usage now, could you help check if desktop used it? @igor-sirotin

@qfrank qfrank self-assigned this Dec 9, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 9, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 19be915 #1 2024-12-09 07:28:06 ~4 min ios 📦zip
✔️ 19be915 #1 2024-12-09 07:28:09 ~4 min macos 📦zip
✔️ 19be915 #1 2024-12-09 07:28:10 ~4 min windows 📦zip
✔️ 19be915 #1 2024-12-09 07:28:38 ~5 min linux 📦zip
✔️ 19be915 #1 2024-12-09 07:28:39 ~5 min android 📦aar
✔️ 19be915 #1 2024-12-09 07:29:37 ~5 min tests-rpc 📄log
✔️ 19be915 #1 2024-12-09 07:31:21 ~7 min macos 📦zip
✔️ 19be915 #1 2024-12-09 07:54:32 ~30 min tests 📄log

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (616a760) to head (19be915).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6182       +/-   ##
============================================
+ Coverage    13.90%   60.87%   +46.97%     
============================================
  Files          817      832       +15     
  Lines       108323   109882     +1559     
============================================
+ Hits         15065    66896    +51831     
+ Misses       91338    35139    -56199     
- Partials      1920     7847     +5927     
Flag Coverage Δ
functional 13.90% <ø> (+<0.01%) ⬆️
unit 60.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mobile/status.go 2.52% <ø> (+2.52%) ⬆️

... and 653 files with indirect coverage changes

Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👌

Technically, it is a breaking change and should be marked as such I believe.

@qfrank
Copy link
Contributor Author

qfrank commented Dec 9, 2024

Technically, it is a breaking change and should be marked as such I believe.

If the desktop and mobile are no longer using this endpoint, it shouldn't be considered a breaking change, right? @osmaczko

@osmaczko
Copy link
Contributor

osmaczko commented Dec 9, 2024

Technically, it is a breaking change and should be marked as such I believe.

If the desktop and mobile are no longer using this endpoint, it shouldn't be considered a breaking change, right? @osmaczko

Not sure. From API point of view, removal is a breaking change. We shouldn't assume desktop and mobile already removed the endpoint usage. Moreover, theoretically, there might be more clients.

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qfrank!
I confirm InitLogging is not used in desktop.

Technically, it is a breaking change and should be marked as such I believe.

@osmaczko fair point, and I'm not sure as well.
I think it makes no sense to mark as breaking in this case.

@qfrank qfrank merged commit e6c2f89 into develop Dec 10, 2024
18 checks passed
@qfrank qfrank deleted the chore/remove-init-logging branch December 10, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants