feat_: API logging objects with zap.Any
#6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
churik,
qfrank,
osmaczko and
anastasiyaig
igor-sirotin
changed the title
zap.Any
igor-sirotin
changed the title
zap.Anyzap.Any
Jenkins BuildsClick to see older builds (47)
|
igor-sirotin
force-pushed
the
feat/api-logging-objects
branch
from
6b10e31 to
2c29d3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6125 +/- ##
===========================================
- Coverage 60.97% 60.95% -0.02%
===========================================
Files 827 827
Lines 109747 109753 +6
===========================================
- Hits 66915 66905 -10
- Misses 34988 35006 +18
+ Partials 7844 7842 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
qfrank
approved these changes
Nov 27, 2024
igor-sirotin
force-pushed
the
feat/InitializeApplication-init-logs
branch
from
42772eb to
e30c6aa
Compare
igor-sirotin
force-pushed
the
feat/api-logging-objects
branch
2 times, most recently
from
b352af2 to
7c6b33f
Compare
Base automatically changed from
feat/InitializeApplication-init-logs
to
develop
November 29, 2024 11:43
igor-sirotin
force-pushed
the
feat/api-logging-objects
branch
from
7c6b33f to
e78b2e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Description
Automatically detect if the request/response is a JSON string (which it is in most cases) and log it as object then.
Example
Before:
{ "method": "InitializeApplication", "params": "{\"dataDir\":\"/Users/igorsirotin/Repositories/Status/status-desktop/Status/data/\",\"mixpanelAppId\":\"3350627\",\"mixpanelToken\":\"5c73bda2d36a9f688a5ee45641fb6775\",\"logEnabled\":true,\"logDir\":\"\",\"logLevel\":\"DEBUG\",\"apiLoggingEnabled\":true}", "resp": "{\"accounts\":null,\"centralizedMetricsInfo\":{\"enabled\":false,\"userConfirmed\":false}}", "duration": "4.534458ms" }After:
{ "method": "InitializeApplication", "duration": "511.916µs", "params": { "apiLoggingEnabled": true, "dataDir": "/Users/igorsirotin/Repositories/Status/status-desktop/Status/data" }, "resp": { "accounts": null, "centralizedMetricsInfo": { "enabled": false, "userConfirmed": false } } }