Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_: one to one messages #6119

Merged
merged 9 commits into from
Dec 3, 2024
Merged

test_: one to one messages #6119

merged 9 commits into from
Dec 3, 2024

Conversation

fbarbu15
Copy link
Contributor

Changes:

  • added 1-1 message tests
  • added small changes that supports those new tests

@status-im-auto
Copy link
Member

status-im-auto commented Nov 25, 2024

Jenkins Builds

Click to see older builds (57)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1ca5d9d #1 2024-11-25 15:07:36 ~4 min ios 📦zip
✖️ 1ca5d9d #1 2024-11-25 15:07:42 ~4 min tests-rpc 📄log
✔️ 1ca5d9d #1 2024-11-25 15:08:28 ~5 min linux 📦zip
✔️ 1ca5d9d #1 2024-11-25 15:09:21 ~6 min android 📦aar
✔️ 1ca5d9d #1 2024-11-25 15:09:27 ~5 min windows 📦zip
✔️ 1ca5d9d #1 2024-11-25 15:10:12 ~6 min macos 📦zip
✔️ 1ca5d9d #1 2024-11-25 15:10:30 ~7 min macos 📦zip
✖️ 1ca5d9d #1 2024-11-25 15:37:20 ~33 min tests 📄log
✔️ 81d2e64 #2 2024-11-25 15:41:28 ~3 min windows 📦zip
✖️ 81d2e64 #2 2024-11-25 15:41:28 ~3 min tests-rpc 📄log
✔️ 81d2e64 #2 2024-11-25 15:42:01 ~4 min ios 📦zip
✔️ 81d2e64 #2 2024-11-25 15:42:08 ~4 min macos 📦zip
✔️ 81d2e64 #2 2024-11-25 15:42:48 ~5 min linux 📦zip
✔️ 81d2e64 #2 2024-11-25 15:43:40 ~6 min android 📦aar
✔️ 81d2e64 #2 2024-11-25 15:44:28 ~6 min macos 📦zip
✔️ 81d2e64 #2 2024-11-25 16:08:46 ~31 min tests 📄log
✔️ 8181ae1 #3 2024-11-25 15:51:58 ~3 min macos 📦zip
✖️ 8181ae1 #3 2024-11-25 15:52:04 ~3 min tests-rpc 📄log
✔️ 8181ae1 #3 2024-11-25 15:52:04 ~3 min windows 📦zip
✔️ 8181ae1 #3 2024-11-25 15:52:27 ~4 min ios 📦zip
✔️ 8181ae1 #3 2024-11-25 15:53:11 ~5 min linux 📦zip
✔️ 8181ae1 #3 2024-11-25 15:54:13 ~6 min android 📦aar
✔️ 8181ae1 #3 2024-11-25 15:55:40 ~7 min macos 📦zip
✔️ 2838419 #4 2024-11-25 16:05:02 ~3 min windows 📦zip
✔️ 2838419 #4 2024-11-25 16:05:53 ~4 min linux 📦zip
✔️ 2838419 #4 2024-11-25 16:06:03 ~4 min macos 📦zip
✔️ 2838419 #4 2024-11-25 16:06:17 ~4 min ios 📦zip
✔️ 2838419 #4 2024-11-25 16:07:05 ~5 min macos 📦zip
✔️ 2838419 #4 2024-11-25 16:08:00 ~6 min android 📦aar
✖️ 2838419 #4 2024-11-25 16:09:12 ~7 min tests-rpc 📄log
✖️ 2838419 #3 2024-11-25 16:40:52 ~31 min tests 📄log
✔️ 1f3f00e #5 2024-11-25 16:27:51 ~3 min windows 📦zip
✔️ 1f3f00e #5 2024-11-25 16:28:01 ~3 min macos 📦zip
✔️ 1f3f00e #5 2024-11-25 16:28:34 ~4 min ios 📦zip
✔️ 1f3f00e #5 2024-11-25 16:28:45 ~4 min linux 📦zip
✔️ 1f3f00e #5 2024-11-25 16:29:16 ~5 min android 📦aar
✖️ 1f3f00e #5 2024-11-25 16:30:25 ~6 min tests-rpc 📄log
✔️ 1f3f00e #5 2024-11-25 16:31:37 ~7 min macos 📦zip
✔️ 1f3f00e #6 2024-11-25 16:44:17 ~6 min tests-rpc 📄log
✖️ 1f3f00e #4 2024-11-25 17:15:22 ~34 min tests 📄log
✔️ c111b53 #6 2024-11-26 17:18:01 ~3 min windows 📦zip
✔️ c111b53 #6 2024-11-26 17:18:58 ~4 min linux 📦zip
✔️ c111b53 #6 2024-11-26 17:18:58 ~4 min macos 📦zip
✔️ c111b53 #6 2024-11-26 17:19:10 ~4 min ios 📦zip
✔️ c111b53 #6 2024-11-26 17:19:46 ~5 min macos 📦zip
✖️ c111b53 #7 2024-11-26 17:19:50 ~5 min tests-rpc 📄log
✔️ c111b53 #6 2024-11-26 17:20:55 ~6 min android 📦aar
✖️ c111b53 #5 2024-11-26 17:45:55 ~31 min tests 📄log
✔️ c111b53 #8 2024-11-26 17:49:39 ~5 min tests-rpc 📄log
✔️ 84adfff #7 2024-11-28 16:44:56 ~4 min ios 📦zip
✔️ 84adfff #9 2024-11-28 16:46:12 ~5 min tests-rpc 📄log
✔️ 84adfff #7 2024-11-28 16:46:46 ~6 min macos 📦zip
✔️ 84adfff #7 2024-11-28 16:47:08 ~6 min windows 📦zip
✔️ 84adfff #7 2024-11-28 16:47:39 ~7 min android 📦aar
✔️ 84adfff #7 2024-11-28 16:47:39 ~7 min macos 📦zip
✔️ 84adfff #7 2024-11-28 16:48:19 ~7 min linux 📦zip
✔️ 84adfff #6 2024-11-28 17:09:32 ~28 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f9ca1c3 #8 2024-11-29 15:49:08 ~4 min windows 📦zip
✔️ f9ca1c3 #8 2024-11-29 15:49:39 ~4 min macos 📦zip
✔️ f9ca1c3 #8 2024-11-29 15:49:52 ~4 min ios 📦zip
✔️ f9ca1c3 #8 2024-11-29 15:50:47 ~5 min android 📦aar
✔️ f9ca1c3 #8 2024-11-29 15:53:45 ~8 min macos 📦zip
✔️ f9ca1c3 #8 2024-11-29 15:55:49 ~10 min linux 📦zip
✖️ f9ca1c3 #10 2024-11-29 15:58:23 ~13 min tests-rpc 📄log
✖️ f9ca1c3 #7 2024-11-29 16:24:42 ~39 min tests 📄log
✔️ f9ca1c3 #11 2024-12-02 11:32:55 ~6 min tests-rpc 📄log
✔️ f9ca1c3 #8 2024-12-02 14:23:07 ~34 min tests 📄log
✔️ 323ab9e #9 2024-12-03 07:14:03 ~4 min ios 📦zip
✔️ 323ab9e #9 2024-12-03 07:14:13 ~4 min macos 📦zip
✔️ 323ab9e #9 2024-12-03 07:15:06 ~5 min macos 📦zip
✔️ 323ab9e #9 2024-12-03 07:15:10 ~5 min linux 📦zip
✔️ 323ab9e #9 2024-12-03 07:15:22 ~5 min android 📦aar
✔️ 323ab9e #12 2024-12-03 07:15:32 ~5 min tests-rpc 📄log
✔️ 323ab9e #9 2024-12-03 07:15:39 ~5 min windows 📦zip
✖️ 323ab9e #9 2024-12-03 07:38:51 ~28 min tests 📄log
✔️ 323ab9e #10 2024-12-03 08:09:48 ~30 min tests 📄log

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (cdc41c3) to head (323ab9e).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6119      +/-   ##
===========================================
- Coverage    61.03%   60.98%   -0.06%     
===========================================
  Files          827      827              
  Lines       109755   109755              
===========================================
- Hits         66993    66937      -56     
- Misses       34940    34976      +36     
- Partials      7822     7842      +20     
Flag Coverage Δ
functional 14.17% <ø> (-0.15%) ⬇️
unit 59.99% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

@fbarbu15 fbarbu15 marked this pull request as ready for review November 25, 2024 16:57
tests-functional/constants.py Show resolved Hide resolved
tests-functional/clients/signals.py Outdated Show resolved Hide resolved
tests-functional/clients/signals.py Outdated Show resolved Hide resolved
tests-functional/constants.py Show resolved Hide resolved
tests-functional/tests/test_cases.py Outdated Show resolved Hide resolved
tests-functional/tests/test_one_to_one_messages.py Outdated Show resolved Hide resolved
tests-functional/tests/test_one_to_one_messages.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review!
addressed all the comments

tests-functional/constants.py Show resolved Hide resolved
tests-functional/clients/signals.py Outdated Show resolved Hide resolved
tests-functional/tests/test_cases.py Outdated Show resolved Hide resolved
tests-functional/tests/test_one_to_one_messages.py Outdated Show resolved Hide resolved
@fbarbu15 fbarbu15 merged commit ec90b2f into develop Dec 3, 2024
17 of 18 checks passed
@fbarbu15 fbarbu15 deleted the test-one-to-one-messages branch December 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants