Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: initial codeowners #6111

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore_: initial codeowners #6111

merged 2 commits into from
Nov 28, 2024

Conversation

igor-sirotin
Copy link
Collaborator

No default code owners for now.
Defined ownership for CI-related code.
Defined my ownership for some folders.

Expecting this file to grow further later.

@igor-sirotin igor-sirotin requested review from a team November 19, 2024 20:10
@igor-sirotin igor-sirotin self-assigned this Nov 19, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Nov 19, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3fbba1e #1 2024-11-19 20:15:34 ~4 min macos 📦zip
✔️ 3fbba1e #1 2024-11-19 20:15:48 ~4 min linux 📦zip
✔️ 3fbba1e #1 2024-11-19 20:16:14 ~5 min ios 📦zip
✔️ 3fbba1e #1 2024-11-19 20:16:20 ~5 min tests-rpc 📄log
✔️ 3fbba1e #1 2024-11-19 20:16:24 ~5 min windows 📦zip
✔️ 3fbba1e #1 2024-11-19 20:17:47 ~6 min android 📦aar
✔️ 3fbba1e #1 2024-11-19 20:18:10 ~7 min macos 📦zip
✔️ 3fbba1e #1 2024-11-19 20:44:57 ~33 min tests 📄log
✔️ 10c76d6 #2 2024-11-28 18:34:19 ~4 min macos 📦zip
✔️ 10c76d6 #2 2024-11-28 18:35:21 ~5 min tests-rpc 📄log
✔️ 10c76d6 #2 2024-11-28 18:35:35 ~5 min linux 📦zip
✔️ 10c76d6 #2 2024-11-28 18:36:19 ~6 min android 📦aar
✔️ 10c76d6 #2 2024-11-28 18:36:27 ~6 min windows 📦zip
✔️ 10c76d6 #2 2024-11-28 18:37:26 ~7 min ios 📦zip
✔️ 10c76d6 #2 2024-11-28 18:37:31 ~7 min macos 📦zip
✖️ 10c76d6 #2 2024-11-28 19:00:10 ~29 min tests 📄log
✔️ 10c76d6 #3 2024-11-28 21:26:58 ~30 min tests 📄log

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.99%. Comparing base (581e477) to head (10c76d6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6111       +/-   ##
============================================
+ Coverage    14.10%   60.99%   +46.88%     
============================================
  Files          812      827       +15     
  Lines       108163   109734     +1571     
============================================
+ Hits         15253    66927    +51674     
+ Misses       90962    34968    -55994     
- Partials      1948     7839     +5891     
Flag Coverage Δ
functional 14.17% <ø> (+0.07%) ⬆️
unit 59.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 650 files with indirect coverage changes

@igor-sirotin
Copy link
Collaborator Author

@status-im/devops can you please take a look if this works for you?

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin force-pushed the chore/initial-codeowners branch from 3fbba1e to 10c76d6 Compare November 28, 2024 18:29
@igor-sirotin igor-sirotin merged commit 9bc5148 into develop Nov 28, 2024
18 checks passed
@igor-sirotin igor-sirotin deleted the chore/initial-codeowners branch November 28, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants