Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Identity Visual Representation #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Identity Visual Representation #166

wants to merge 1 commit into from

Conversation

osmaczko
Copy link

@osmaczko osmaczko commented Feb 16, 2022 •
edited
Loading

jrainville
jrainville reviewed Feb 17, 2022
View reviewed changes
docs/spec/2-account.md Outdated
- Emoji Hash MUST be one of `n` distinctive emojis
- emojis set of length `n` used for Emoji Hash MUST be immutable

Emoji Hash to be collision resistant MUST fulfill given equasion: $\frac{n!}{(n-len)!} \geq 2^{(17*8)}$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formulas are sadly not understandable in the MD format.

@osmaczko osmaczko force-pushed the feature/identity-visual-repr branch from 575c4b6 to 90b67f2 Compare February 18, 2022 12:59
@osmaczko osmaczko marked this pull request as ready for review February 18, 2022 13:01
@osmaczko osmaczko force-pushed the feature/identity-visual-repr branch 2 times, most recently from 35ee9b2 to 17ab4b3 Compare February 18, 2022 13:38
John-44
John-44 approved these changes Feb 18, 2022
View reviewed changes
Copy link

@John-44 John-44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion below, based on this discussion +1 from me :-)

2022-02-18 14_27_44-Patryk - Discord

This was referenced Feb 21, 2022
Open
Merged
@osmaczko osmaczko force-pushed the feature/identity-visual-repr branch 2 times, most recently from b672345 to 2dfe1b9 Compare May 4, 2022 19:03
@osmaczko osmaczko force-pushed the feature/identity-visual-repr branch from 2dfe1b9 to afe53b5 Compare May 4, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville left review comments

@John-44 John-44 John-44 approved these changes

@Samyoul Samyoul Awaiting requested review from Samyoul

@0kok0 0kok0 Awaiting requested review from 0kok0

@vitvly vitvly Awaiting requested review from vitvly

@cammellos cammellos Awaiting requested review from cammellos

@iurimatias iurimatias Awaiting requested review from iurimatias

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osmaczko @jrainville @John-44