Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment option to Contentful connection #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cinnamonKale
Copy link

This adds a new option to contentful.createClient() that allows for different environments to be specified. More info on environments here.

The default value is master, which is default in every Contentful space. Since environments can be named anything it's up to the user to specify the ID of any other environment.

Next steps:

  1. Add tests

@jescalan
Copy link
Member

Looking great so far! Ping me when tests are ready 😀

@cinnamonKale
Copy link
Author

@jescalan I think in order to add tests for the staging environment one will need to be created in Contentful. Is that something you can handle, or give access to?

@jescalan
Copy link
Member

Unfortunately I can't actually, this package uses contentful's example space which is under their control. I pulled this from some docs and and contentful's own open source libraries. I might try poking around there a bit, or reaching out to contentful?

@cinnamonKale
Copy link
Author

Good to know. I'll do some research

@cinnamonKale
Copy link
Author

@jescalan is this project still maintained? I noticed spike isn't, but if there's still value in it I'll continue to look into setting up a different example space for tests

@jescalan
Copy link
Member

jescalan commented Jan 9, 2020

I am not maintaining it personally, but it should still work, and you're welcome to contribute if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants