-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fri par domain iter #993
fri par domain iter #993
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #993 +/- ##
=======================================
Coverage 91.91% 91.92%
=======================================
Files 105 105
Lines 14289 14297 +8
Branches 14289 14297 +8
=======================================
+ Hits 13134 13142 +8
Misses 1081 1081
Partials 74 74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
crates/prover/src/core/backend/simd/quotients.rs
line 250 at r1 (raw file):
iter.clone() .map(|points| (prx - points.x) * piy - (pry - points.y) * pix) .collect::<Vec<_>>()
Can you revert to collect_vec?
Code quote:
.collect::<Vec<_>>()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
crates/prover/src/core/backend/simd/quotients.rs
line 250 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Can you revert to collect_vec?
no, when using rayon, the "map" is not the regular map, and doesn't have a collect vec
No description provided.