Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fri par domain iter #993

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fri par domain iter #993

merged 1 commit into from
Jan 14, 2025

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (71516ef) to head (809a869).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #993   +/-   ##
=======================================
  Coverage   91.91%   91.92%           
=======================================
  Files         105      105           
  Lines       14289    14297    +8     
  Branches    14289    14297    +8     
=======================================
+ Hits        13134    13142    +8     
  Misses       1081     1081           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)


crates/prover/src/core/backend/simd/quotients.rs line 250 at r1 (raw file):

            iter.clone()
                .map(|points| (prx - points.x) * piy - (pry - points.y) * pix)
                .collect::<Vec<_>>()

Can you revert to collect_vec?

Code quote:

.collect::<Vec<_>>()

Copy link
Collaborator Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


crates/prover/src/core/backend/simd/quotients.rs line 250 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you revert to collect_vec?

no, when using rayon, the "map" is not the regular map, and doesn't have a collect vec

@ohad-starkware ohad-starkware merged commit d05215c into dev Jan 14, 2025
16 of 19 checks passed
@ohad-starkware ohad-starkware deleted the ohad/par_fri_domain_iter branch January 14, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants