Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packed_at() to PreProcessed Column Enum #360

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

Gali-StarkWare
Copy link
Contributor

@Gali-StarkWare Gali-StarkWare commented Jan 16, 2025

This change is Reviewable

@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review January 16, 2025 14:00
Copy link
Contributor Author

Gali-StarkWare commented Jan 16, 2025

@Gali-StarkWare Gali-StarkWare self-assigned this Jan 16, 2025
@Gali-StarkWare Gali-StarkWare requested review from alon-f and removed request for shaharsamocha7 January 16, 2025 14:06
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/move_preprocessed_structs to graphite-base/360 January 16, 2025 14:08
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/360 to main January 16, 2025 14:09
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-f)

Copy link

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare)


stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 59 at r1 (raw file):

    pub fn packed_at(&self, vec_row: usize) -> PackedM31 {
        match self {
            PreProcessedColumn::IsFirst(column) => column.packed_at(vec_row),

blocked

Copy link

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Gali-StarkWare)

@Gali-StarkWare Gali-StarkWare merged commit 9ed0d6c into main Jan 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants