-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Git experiment #294
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)
stwo_cairo_prover/crates/prover/src/input/plain.rs
line 28 at r1 (raw file):
.collect_vec(); // TODO(yg): revert
very bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)
stwo_cairo_prover/crates/prover/src/input/plain.rs
line 29 at r1 (raw file):
// TODO(yg): revert let program_len = felt_code.len();
very very bad
bc0cc64
to
17a6246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @yuvalsw)
stwo_cairo_prover/crates/prover/src/input/plain.rs
line 29 at r2 (raw file):
// TODO(yg): revertttt let program_len = felt_code.len();
test test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Stavbe)
stwo_cairo_prover/crates/prover/src/input/plain.rs
line 31 at r2 (raw file):
let program_len = felt_code.len(); let program = cairo_vm::types::program::Program::new_for_proof( vec![],
dfgdfg
17a6246
to
7167fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Stavbe)
stwo_cairo_prover/crates/prover/src/input/plain.rs
line 31 at r2 (raw file):
let program_len = felt_code.len(); let program = cairo_vm::types::program::Program::new_for_proof( vec![],
dfgdfg
This change is