Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Git experiment #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DO NOT MERGE: Git experiment #294

wants to merge 1 commit into from

Conversation

yuvalsw
Copy link
Collaborator

@yuvalsw yuvalsw commented Dec 31, 2024

This change is Reviewable

Copy link
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)


stwo_cairo_prover/crates/prover/src/input/plain.rs line 28 at r1 (raw file):

        .collect_vec();

    // TODO(yg): revert

very bad

Copy link
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)


stwo_cairo_prover/crates/prover/src/input/plain.rs line 29 at r1 (raw file):

    // TODO(yg): revert
    let program_len = felt_code.len();

very very bad

@yuvalsw yuvalsw force-pushed the yuval/git_experiment branch from bc0cc64 to 17a6246 Compare January 1, 2025 06:33
Copy link
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @yuvalsw)


stwo_cairo_prover/crates/prover/src/input/plain.rs line 29 at r2 (raw file):

    // TODO(yg): revertttt
    let program_len = felt_code.len();

test test

Copy link
Collaborator Author

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

Copy link
Collaborator Author

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Stavbe)


stwo_cairo_prover/crates/prover/src/input/plain.rs line 31 at r2 (raw file):

    let program_len = felt_code.len();
    let program = cairo_vm::types::program::Program::new_for_proof(
        vec![],

dfgdfg

@yuvalsw yuvalsw force-pushed the yuval/git_experiment branch from 17a6246 to 7167fe8 Compare January 6, 2025 14:43
Copy link
Collaborator Author

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Stavbe)


stwo_cairo_prover/crates/prover/src/input/plain.rs line 31 at r2 (raw file):

    let program_len = felt_code.len();
    let program = cairo_vm::types::program::Program::new_for_proof(
        vec![],

dfgdfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants