Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change CairoInput to ProverInput #280

Merged
merged 1 commit into from
Dec 31, 2024
Merged

change CairoInput to ProverInput #280

merged 1 commit into from
Dec 31, 2024
+22 −23

Conversation

Stavbe
Copy link
Contributor

@Stavbe Stavbe commented Dec 26, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

This was referenced Dec 26, 2024
Merged
Merged
@Stavbe Graphite App
Copy link
Contributor Author

Stavbe commented Dec 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Stavbe Stavbe marked this pull request as ready for review December 26, 2024 14:59
ohad-starkware
ohad-starkware reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate that name very much, please explain the reason

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @yuvalsw)

ohad-starkware
ohad-starkware reviewed Dec 28, 2024
View reviewed changes
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrote suggestions in #274

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @yuvalsw)

@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 52446a3 to 4114266 Compare December 29, 2024 09:52
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from e9fca54 to 8dbcdfe Compare December 29, 2024 09:52
@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 4114266 to 32415d4 Compare December 29, 2024 13:13
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 8dbcdfe to cb7e484 Compare December 29, 2024 13:13
@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 32415d4 to 5bba2e8 Compare December 29, 2024 14:55
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from cb7e484 to c215a0c Compare December 29, 2024 14:55
yuvalsw
yuvalsw approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

LGTM for either StwoInput or ProverInput (but Ohad seems to prefer ProverInput, so let's go with it).

Reviewed 1 of 7 files at r1, 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Stavbe)

@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 5bba2e8 to 3379f9a Compare December 30, 2024 09:23
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from c215a0c to cced16a Compare December 30, 2024 09:23
@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 3379f9a to 8da963a Compare December 30, 2024 09:48
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch 3 times, most recently from 0eb548f to 1adbbe8 Compare December 30, 2024 09:52
Stavbe
Stavbe commented Dec 30, 2024
View reviewed changes
Copy link
Contributor Author

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @yuvalsw)

@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 8da963a to aaabc3a Compare December 30, 2024 12:31
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 1adbbe8 to 2031223 Compare December 30, 2024 12:31
yuvalsw
yuvalsw approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please fix the commit message (commit --amend) and the title of the PR (through github)

Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Stavbe)

@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from aaabc3a to fe6bbc3 Compare December 31, 2024 09:19
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 2031223 to 1679bcb Compare December 31, 2024 09:19
@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from fe6bbc3 to 33560e3 Compare December 31, 2024 09:29
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 1679bcb to ec69490 Compare December 31, 2024 09:29
@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch from 33560e3 to a59c3fd Compare December 31, 2024 09:31
@Stavbe Stavbe force-pushed the 12-23-unify_adapter_functionality branch 2 times, most recently from 36881d4 to 10beba0 Compare December 31, 2024 09:32
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch 2 times, most recently from 6a88131 to 7d87500 Compare December 31, 2024 09:35
@Stavbe Stavbe mentioned this pull request Dec 31, 2024
Closed
@Stavbe Stavbe changed the base branch from 12-23-unify_adapter_functionality to graphite-base/280 December 31, 2024 10:00
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 7d87500 to 8d8521f Compare December 31, 2024 10:01
@Stavbe Stavbe changed the base branch from graphite-base/280 to main December 31, 2024 10:01
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 8d8521f to f73a690 Compare December 31, 2024 10:01
yuvalsw
yuvalsw approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Stavbe)

@Stavbe Stavbe changed the title change CairoInput to StwoInput change CairoInput to ProverInput Dec 31, 2024
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from f73a690 to 721b8e2 Compare December 31, 2024 10:36
@Stavbe Stavbe force-pushed the 12-26-change_cairoinput_to_stwoinput branch from 721b8e2 to 06e712a Compare December 31, 2024 10:39
ohad-starkware
ohad-starkware approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @Stavbe)

@Stavbe Stavbe merged commit 983971c into main Dec 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohad-starkware ohad-starkware ohad-starkware approved these changes

@yuvalsw yuvalsw yuvalsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stavbe @yuvalsw @ohad-starkware