Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove execution resources from block hash #269

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Jun 4, 2024

This change is Reviewable

@yoavGrs yoavGrs self-assigned this Jun 4, 2024
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)


src/block_hash/block_hash_calculator.rs line 14 at r1 (raw file):

use crate::data_availability::L1DataAvailabilityMode;
use crate::state::ThinStateDiff;
use crate::transaction::{TransactionHash, TransactionOutputCommon, TransactionSignature};

this struct is not used anywhere anymore; delete it please

Code quote:

TransactionOutputCommon

@yoavGrs yoavGrs force-pushed the yoav/block_hash/remove_execution_resources branch from bba8ee9 to f0b91f9 Compare June 4, 2024 11:31
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs)


src/block_hash/block_hash_calculator.rs line 14 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this struct is not used anywhere anymore; delete it please

Done.

@yoavGrs yoavGrs force-pushed the yoav/block_hash/remove_execution_resources branch from f0b91f9 to 4575902 Compare June 4, 2024 11:55
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs merged commit 4bc26ac into main Jun 4, 2024
6 checks passed
@yoavGrs yoavGrs deleted the yoav/block_hash/remove_execution_resources branch June 4, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants