Mohammad/external tx/resource bounds/implement from trait

[MohammadNassar1]

This change is 

[elintul]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)

---

src/external_transaction.rs line 172 at r1 (raw file):

}

impl From<ResourceBoundsMapping> for crate::transaction::ResourceBoundsMapping {

I'm confused; why do we need both types?

Code quote:

crate::transaction::ResourceBoundsMapping

[MohammadNassar1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)

---

src/external_transaction.rs line 172 at r1 (raw file):

Previously, elintul (Elin) wrote…

I'm confused; why do we need both types?

The RPC field expects small letters l1_gas & l2_gas.
While the transaction is Capital letters, which doesn't follow the spec.

[elintul]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)

---

src/external_transaction.rs line 176 at r1 (raw file):

        let mut map = BTreeMap::new();
        map.insert(Resource::L1Gas, mapping.l1_gas);
        map.insert(Resource::L2Gas, mapping.l2_gas);

Please use a BTreeMap c-tor from tuples.

Code quote:

        let mut map = BTreeMap::new();
        map.insert(Resource::L1Gas, mapping.l1_gas);
        map.insert(Resource::L2Gas, mapping.l2_gas);

[MohammadNassar1]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @elintul)

---

src/external_transaction.rs line 176 at r1 (raw file):

Previously, elintul (Elin) wrote…

Please use a BTreeMap c-tor from tuples.

Done

[elintul]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)