Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: not typed transaction output object for block hash #260

Merged
merged 1 commit into from
May 21, 2024
Merged

feat: not typed transaction output object for block hash #260

merged 1 commit into from
May 21, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented May 21, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

@yoavGrs yoavGrs self-assigned this May 21, 2024
dorimedini-starkware
dorimedini-starkware approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@yoavGrs yoavGrs merged commit 36bc27a into main May 21, 2024
6 checks passed
@yoavGrs yoavGrs deleted the yoav/block_hash/transaction_output_common branch May 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@ShahakShama ShahakShama Awaiting requested review from ShahakShama

Assignees

@yoavGrs yoavGrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoavGrs @dorimedini-starkware