feat: concat_counts into a single felt

[yoavGrs]

This change is 

[ShahakShama]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @yoavGrs)

---

src/block_hash/block_hash_calculator.rs line 1 at r1 (raw file):

use crate::data_availability::L1DataAvailabilityMode;

Rename this file to util

---

src/block_hash/block_hash_calculator.rs line 37 at r1 (raw file):

fn to_64_bits(num: usize, error_message: String) -> Result<[u8; 8], StarknetApiError> {
    let sized_transaction_count: u64 =
        num.try_into().map_err(|_| StarknetApiError::OutOfRange { string: error_message })?;

usize to u64 will always succeed on almost all computers. You can use expect instead of map_err

---

src/block_hash/block_hash_calculator_test.rs line 1 at r1 (raw file):

use super::concat_counts;

And this to util_test

[yoavGrs]

Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @ShahakShama)

---

src/block_hash/block_hash_calculator.rs line 1 at r1 (raw file):

Previously, ShahakShama wrote…

Rename this file to util

I plan to add fn calculate_block_hash to this file in the next PR.

---

src/block_hash/block_hash_calculator.rs line 37 at r1 (raw file):

Previously, ShahakShama wrote…

usize to u64 will always succeed on almost all computers. You can use expect instead of map_err

Done.

---

src/block_hash/block_hash_calculator_test.rs line 1 at r1 (raw file):

Previously, ShahakShama wrote…

And this to util_test

Same as above

[ShahakShama]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[ShahakShama]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

src/block_hash/block_hash_calculator.rs line 19 at r2 (raw file):

    state_diff_length: usize,
    l1_data_availability_mode: L1DataAvailabilityMode,
) -> Result<StarkFelt, StarknetApiError> {

Change the return type

[yoavGrs]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

src/block_hash/block_hash_calculator.rs line 19 at r2 (raw file):

Previously, ShahakShama wrote…

Change the return type

This Result comes from the new StrakFelt.
IMO new_unchecked is fine here.

[ShahakShama]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

src/block_hash/block_hash_calculator.rs line 19 at r2 (raw file):

Previously, yoavGrs wrote…

This Result comes from the new StrakFelt.
IMO new_unchecked is fine here.

I agree with you. use new_unchecked

[ShahakShama]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)