Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cairo-lang-starknet dep to 2.5.0-dev.0 #167

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

zuphitf
Copy link
Contributor

@zuphitf zuphitf commented Dec 27, 2023

This change is Reviewable

@zuphitf zuphitf self-assigned this Dec 27, 2023
@zuphitf zuphitf force-pushed the zuphit/update_cairo_vm/0.9.1 branch from af70929 to 5d3d4c4 Compare December 27, 2023 09:32
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zuphitf)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zuphitf)

a discussion (no related file):
did you run cargo build?


@zuphitf
Copy link
Contributor Author

zuphitf commented Dec 27, 2023

Previously, dorimedini-starkware wrote…

did you run cargo build?

Yes, of course.
Cargo.lock is in .gitignore in this repo.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zuphitf)

@zuphitf zuphitf added this pull request to the merge queue Dec 27, 2023
Merged via the queue into main with commit 03cce46 Dec 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants